FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Usage-server update message improvement by andrijapanicsb · Pull Request #4278 · apache/cloudstack · GitHub

/ cloudstack Public

Usage-server update message improvement - #4278

Merged
yadvr merged 3 commits into
masterfrom
update-message-for-usage-server
Aug 23, 2020
ConversationCommits (3)ChecksFiles changed
Merged

Usage-server update message improvement#4278
yadvr merged 3 commits into
masterfrom
update-message-for-usage-server

Conversation

andrijapanicsb commented Aug 21, 2020 •
edited by PaulAngus
Loading

Copy link
Copy Markdown
Contributor

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Minor improvement of the usage-server's update message, to make it clear to the user what is being done.

andrijapanicsb changed the title Update cloud.spec Usage-server update message improvement Aug 21, 2020
andrijapanicsb requested a review from yadvr August 21, 2020 08:30
andrijapanicsb added this to the 4.15.0.0 milestone Aug 21, 2020

yadvr commented Aug 21, 2020

Copy link
Copy Markdown
Member

LGTM full test run not necessary, only echo statement changes
@blueorangutan package

blueorangutan commented Aug 21, 2020

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Aug 21, 2020

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1801

RodrigoDLopez commented Aug 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

LGTM

GabrielBrascher approved these changes Aug 21, 2020
View reviewed changes

GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

yadvr merged commit cddf69c into master Aug 23, 2020
andrijapanicsb deleted the update-message-for-usage-server branch June 8, 2026 20:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
GabrielBrascher GabrielBrascher approved these changes

Assignees

No one assigned

Labels

Severity:Trivial type:cleanup

Projects

None yet

Milestone

4.15.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL