FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ui: deprecate old UI and move to legacy to be served at /client/legacy by yadvr · Pull Request #4518 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

ui: deprecate old UI and move to legacy to be served at /client/legacy - #4518

Merged
yadvr merged 3 commits into
apache:masterfrom
shapeblue:ui-deprecation
Dec 5, 2020
ConversationCommits (3)ChecksFiles changed
Merged

ui: deprecate old UI and move to legacy to be served at /client/legacy#4518
yadvr merged 3 commits into
apache:masterfrom
shapeblue:ui-deprecation

Conversation

yadvr commented Dec 4, 2020

Copy link
Copy Markdown
Member

As notified in the 4.14.0.0 release notes, this deprecates the legacy UI
and moves it under the ui/legacy directory which will be served at
/client/legacy URL path. This will also ensure that users upgrading or
installing 4.15.0.0 will get the new UI by default. This will also make
it simpler to remove the old UI for future 4.16/master releases.

The removal notice has been added here: https://github.com/apache/cloudstack-documentation/blob/master/source/releasenotes/about.rst#primate-ga-and-legacy-ui-deprecation-and-removal-notice

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

ui: deprecate old UI and move to legacy to be served at /client/legacy
8eea07f 
As notified in the 4.14.0.0 release notes, this deprecates the legacy UI
and moves it under the ui/legacy directory which will be served at
/client/legacy URL path. This will also ensure that users upgrading or
installing 4.15.0.0 will get the new UI by default. This will also make
it simpler to remove the old UI for future 4.16/master releases.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
yadvr added this to the 4.15.0.0 milestone Dec 4, 2020

yadvr commented Dec 4, 2020

Copy link
Copy Markdown
Member Author

This is strictly UI only change, screenshots:

I'll add details on what we're doing here on the on-going email thread on dev@ ML later today.

yadvr commented Dec 4, 2020

Copy link
Copy Markdown
Member Author

Basic sanitation check:
@blueorangutan package

blueorangutan commented Dec 4, 2020

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

DaanHoogland reviewed Dec 4, 2020
View reviewed changes
Comment thread ui/index.html

<!-- Load this script after all scripts have executed to populate data -->
<script type="text/javascript" src="scripts/postLoad.js"></script>
<p>The legacy UI has been deprecated in this version as notified in the <a href="http://docs.cloudstack.apache.org/en/4.14.0.0/releasenotes/about.html#new-user-interface-depreciation-notice-of-existing-ui">previous release</a>. The legacy UI will be <a href="http://docs.cloudstack.apache.org/en/4.15.0.0/releasenotes/about.html#primate-ga-and-legacy-ui-deprecation-and-removal-notice">removed in the next release</a>.<br/>To access the legacy UI <a href="legacy">click here</a>.</p>

DaanHoogland Dec 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I wouldn't even make it a link, justr the instruction "add '/lagacy' to the url in your browser"

yadvr Dec 4, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Actually most users won't see this as the new UI (Primate) will get installed over the folder overwriting this index.html with its own.

DaanHoogland reviewed Dec 4, 2020
View reviewed changes
Comment thread ui/legacy/index.html
<link type="text/css" rel="stylesheet" href="css/custom.css" />
</head>
<body>
<!-- CloudStack widget content -->

DaanHoogland Dec 4, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

should we add a big deprecation banner here as well?

yadvr Dec 4, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we could, let me see if I can put something together.

wido approved these changes Dec 4, 2020
View reviewed changes

wido left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Nice work all!

blueorangutan commented Dec 4, 2020

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2460

legacy: add deprecation banner/notice at the top
574a60b 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr commented Dec 4, 2020

Copy link
Copy Markdown
Member Author

Thanks @wido

@DaanHoogland I've added the banner, can you review:

yadvr requested a review from DaanHoogland December 4, 2020 17:46

yadvr commented Dec 4, 2020

Copy link
Copy Markdown
Member Author

@blueorangutan package

blueorangutan commented Dec 4, 2020

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

GabrielBrascher approved these changes Dec 4, 2020
View reviewed changes

GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the changes @rhtyd!

LGTM

blueorangutan commented Dec 4, 2020

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2462

yadvr closed this Dec 5, 2020
yadvr reopened this Dec 5, 2020

yadvr commented Dec 5, 2020

Copy link
Copy Markdown
Member Author

Did several tests, UI works OK after moving to legacy/ path. I'll merge this to test the bundling of primate build with 4.15/master pkgs next. Merging based on 2 lgtms and manual testing.

yadvr merged commit 02f80d3 into apache:master Dec 5, 2020
yadvr deleted the ui-deprecation branch December 5, 2020 15:07

blueorangutan commented Dec 5, 2020

Copy link
Copy Markdown

Trillian test result (tid-3309)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26009 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4518-t3309-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 76 look OK, 4 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_13_retrieve_vr_default_files Error 1.13 test_diagnostics.py
test_14_retrieve_vr_one_file Error 1.12 test_diagnostics.py
test_15_retrieve_ssvm_default_files Error 1.14 test_diagnostics.py
test_16_retrieve_ssvm_single_file Error 1.14 test_diagnostics.py
test_17_retrieve_cpvm_default_files Error 1.14 test_diagnostics.py
test_18_retrieve_cpvm_single_file Error 1.14 test_diagnostics.py
test_04_extract_Iso Failure 1.09 test_iso.py
test_04_extract_template Failure 1.10 test_templates.py
test_01_migrate_VM_and_root_volume Error 58.71 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 48.77 test_vm_life_cycle.py

qrry added a commit to qrry/cloudstack that referenced this pull request Dec 23, 2020
Merge branch 'master' into dev
7b74988 
* master:
  server: add conditions for custom offerings (apache#4540)
  vr: Ensuring dnsmasq.leases file is populated (apache#4529)
  template: Ensuring template is cross zone if type changed to system (apache#4522)
  storage: Fix hypervisor type cast to string (apache#4516)
  db upgrade: fix sql exception: Access denied; you need (at least one of) the SUPER privilege(s) for this operation (apache#4533)
  CLOUDSTACK-10423:Potential sensitive information disclosure (apache#4536)
  jobs: The patch remove the password from resultObject and make it be humanreadable (apache#4538)
  listphysicalnetworks: Honouring keyword parameter (apache#4511)
  Fix NPE when Volume exists on secondary store but doesn't have a download URL (apache#4530)
  apidoc issue (apache#4532)
  db: Fix description of volume.stats.interval which is in milliseconds not seconds (apache#4526)
  kvm: set cpu topology only if cpucore per socket is positive value (apache#4527)
  xenserver: check and eject patch vbd for systemvms (apache#4525)
  Fix warning when setup cloudstack-common (apache#4523)
  kvm: FIX cpucorespersocket is not working on KVM (apache#4497)
  change debug to warn for unknown exceptions (apache#4521)
  Fix failure in validating IP address in case of multiple Management Servers (apache#4507)
  Update log output for FirstFitPlanner (apache#4515)
  ui: deprecate old UI and move to legacy to be served at /client/legacy (apache#4518)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

wido wido approved these changes
GabrielBrascher GabrielBrascher approved these changes
PaulAngus Awaiting requested review from PaulAngus
davidjumani Awaiting requested review from davidjumani
harikrishna-patnala Awaiting requested review from harikrishna-patnala
Pearl1594 Awaiting requested review from Pearl1594
sureshanaparti Awaiting requested review from sureshanaparti
weizhouapache Awaiting requested review from weizhouapache
DaanHoogland Awaiting requested review from DaanHoogland

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.15.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL