FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow users to update volume name by ravening · Pull Request #4618 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Allow users to update volume name - #4618

Merged
nvazquez merged 1 commit into
apache:mainfrom
ravening:update-volume
Aug 19, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Allow users to update volume name#4618
nvazquez merged 1 commit into
apache:mainfrom
ravening:update-volume

Conversation

ravening commented Jan 26, 2021

Copy link
Copy Markdown
Member

Provide an api support to update volume name by all users
UI changes ported from apache/cloudstack-primate#920

Description

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

ravening mentioned this pull request Jan 26, 2021
Closed
3 of 12 tasks

DaanHoogland commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

@ravening I recall this being discussed before. is it a reopening with old code?

DaanHoogland commented Jan 27, 2021

Copy link
Copy Markdown
Contributor

yes, to answer my own question: #4584

shwstppr added this to the 4.16.0.0 milestone Feb 8, 2021

yadvr commented Mar 6, 2021

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented Mar 6, 2021

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Mar 6, 2021

Copy link
Copy Markdown

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2879

yadvr closed this Apr 5, 2021
yadvr reopened this Apr 5, 2021

yadvr commented Apr 5, 2021

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented Apr 5, 2021

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Apr 5, 2021

Copy link
Copy Markdown

Packaging result: ✖️ centos7 ✔️ centos8 ✔️ debian. SL-JID 326

yadvr commented Jun 17, 2021

Copy link
Copy Markdown
Member

ping @ravening can you fix the conflicts

sureshanaparti commented Jun 25, 2021

Copy link
Copy Markdown
Contributor

Hi @ravening, Can you resolve the code conflicts.

nvazquez commented Jul 27, 2021

Copy link
Copy Markdown
Contributor

Hi @ravening can you please resolve the conflicts?

ravening commented Jul 30, 2021

Copy link
Copy Markdown
Member Author

Hi @ravening can you please resolve the conflicts?

@rhtyd @sureshanaparti @nvazquez will work on it today.
I didnt get any notification from github on tagging my username and so was unaware of this

yadvr commented Aug 9, 2021

Copy link
Copy Markdown
Member

@ravening ping - can you fix the conflict? You can enable email settings in your github https://github.com/settings/notifications

ravening commented Aug 18, 2021

Copy link
Copy Markdown
Member Author

@ravening ping - can you fix the conflict? You can enable email settings in your github https://github.com/settings/notifications

@rhtyd yes thats all enabled.. no idea why its not sending notifications!

Allow users to update volume name
21f45d0 
Provide an api support to update volume name by all users

nvazquez commented Aug 19, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Aug 19, 2021

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

nvazquez approved these changes Aug 19, 2021
View reviewed changes

nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code LGTM

blueorangutan commented Aug 19, 2021

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 919

nvazquez commented Aug 19, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented Aug 19, 2021

Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Aug 19, 2021

Copy link
Copy Markdown

Trillian test result (tid-1706)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34257 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4618-t1706-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

nvazquez merged commit ee01522 into apache:main Aug 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland approved these changes
nvazquez nvazquez approved these changes
weizhouapache weizhouapache approved these changes
+1 more reviewer
RodrigoDLopez RodrigoDLopez approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:api type:enhancement

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL