FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ui: fix update vm details wrt backend changes by shwstppr · Pull Request #4670 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

ui: fix update vm details wrt backend changes - #4670

Merged
yadvr merged 1 commit into
apache:4.15from
shapeblue:fix-ui-vm-readonly-settings
Mar 11, 2021
ConversationCommits (1)ChecksFiles changed
Merged

ui: fix update vm details wrt backend changes#4670
yadvr merged 1 commit into
apache:4.15from
shapeblue:fix-ui-vm-readonly-settings

Conversation

shwstppr commented Feb 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

PR #4629 made changes in updateVirtualMachine behaviour wrt readonly details.
This change updates UI wrt new behaviour.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  • Deployed a VM as user.
  • As admin added a new detail to the VM. Made the detail read-only by putting it in global config - user.vm.readonly.ui.details
  • As user, tried add, edit and delete details operation on the VM.


ui: fix update vm details wrt backend changes
e2d4421 
PR apache#4629 made changes in updateVirtualMachine behaviour wrt readonly details.
This change updates UI wrt new behaviour.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
shwstppr added this to the 4.15.1.0 milestone Feb 9, 2021

shwstppr commented Feb 9, 2021

Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

blueorangutan commented Feb 9, 2021

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Feb 9, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4670 (JID-3834)

Pearl1594 commented Feb 11, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented Feb 11, 2021

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Feb 11, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4670 (JID-3835)

blueorangutan commented Feb 11, 2021

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Pearl1594 commented Feb 11, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented Feb 11, 2021

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Pearl1594 commented Feb 11, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented Feb 11, 2021

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Feb 11, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4670 (JID-12)

yadvr self-requested a review February 26, 2021 07:03
shwstppr marked this pull request as ready for review March 1, 2021 06:40

weizhouapache commented Mar 1, 2021

Copy link
Copy Markdown
Member

@shwstppr can you upload some screenshots for this ui change ?

shwstppr commented Mar 1, 2021

Copy link
Copy Markdown
Contributor Author

@weizhouapache added screenshot

davidjumani commented Mar 6, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented Mar 6, 2021

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Mar 6, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4670 (JID-3850)

yadvr approved these changes Mar 6, 2021
View reviewed changes

yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, needs testing

yadvr commented Mar 11, 2021

Copy link
Copy Markdown
Member

Tests LGTM - from gif. Fixes existing UI minor feature from legacy UI.

yadvr merged commit a691e87 into apache:4.15 Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
davidjumani Awaiting requested review from davidjumani
Pearl1594 Awaiting requested review from Pearl1594
weizhouapache Awaiting requested review from weizhouapache

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.15.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL