FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

UI: Add cancel button missing on dialog by utchoang · Pull Request #4763 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

UI: Add cancel button missing on dialog - #4763

Merged
yadvr merged 2 commits into
apache:4.15from
utchoang:feature/dialog-add-cancel-button
Mar 29, 2021
ConversationCommits (2)ChecksFiles changed
Merged

UI: Add cancel button missing on dialog#4763
yadvr merged 2 commits into
apache:4.15from
utchoang:feature/dialog-add-cancel-button

Conversation

utchoang commented Mar 8, 2021 •
edited
Loading

Copy link
Copy Markdown

Description

This PR for the fix to add cancel button missing on dialog

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

After fix:

How Has This Been Tested?

utchoang closed this Mar 8, 2021
utchoang deleted the feature/dialog-add-cancel-button branch March 8, 2021 06:23
utchoang restored the feature/dialog-add-cancel-button branch March 8, 2021 06:23
utchoang reopened this Mar 8, 2021
utchoang mentioned this pull request Mar 8, 2021
Merged
3 of 12 tasks

utchoang commented Mar 8, 2021

Copy link
Copy Markdown
Author

@blueorangutan ui

blueorangutan commented Mar 8, 2021

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Mar 8, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4763 (JID-3853)

DaanHoogland added this to the 4.15.1.0 milestone Mar 8, 2021
utchoang marked this pull request as draft March 9, 2021 01:57
utchoang marked this pull request as ready for review March 11, 2021 08:59
utchoang requested review from shwstppr and yadvr March 15, 2021 06:06
utchoang mentioned this pull request Mar 16, 2021
Closed

yadvr commented Mar 24, 2021

Copy link
Copy Markdown
Member

@blueorangutan ui

blueorangutan commented Mar 24, 2021

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Mar 24, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4763 (SL-JID-54)

davidjumani commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

@utchoang Could you remove the commit d998f27 and push ?

utchoang closed this Mar 25, 2021
utchoang force-pushed the feature/dialog-add-cancel-button branch from a6297a8 to 3a82392 Compare March 25, 2021 07:19
utchoang reopened this Mar 25, 2021

davidjumani commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented Mar 25, 2021

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Mar 25, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4763 (SL-JID-73)

davidjumani approved these changes Mar 25, 2021
View reviewed changes

davidjumani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

yadvr merged commit 3e8dbc0 into apache:4.15 Mar 29, 2021
utchoang deleted the feature/dialog-add-cancel-button branch March 30, 2021 00:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

davidjumani davidjumani approved these changes
yadvr Awaiting requested review from yadvr
shwstppr Awaiting requested review from shwstppr

Assignees

davidjumani

Labels

None yet

Projects

None yet

Milestone

4.15.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL