FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

UI: Save and auto-expand list domain when reloading by utchoang · Pull Request #4769 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

UI: Save and auto-expand list domain when reloading - #4769

Merged
yadvr merged 7 commits into
apache:4.15from
utchoang:feature/auto-expand-domain
Apr 6, 2021
ConversationCommits (7)ChecksFiles changed
Merged

UI: Save and auto-expand list domain when reloading#4769
yadvr merged 7 commits into
apache:4.15from
utchoang:feature/auto-expand-domain

Conversation

utchoang commented Mar 8, 2021 •
edited
Loading

Copy link
Copy Markdown

Description

This PR for a fix while listing domains, on full page reload, it goes back to the root domain

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

utchoang mentioned this pull request Mar 8, 2021
Merged
3 of 12 tasks

utchoang commented Mar 8, 2021

Copy link
Copy Markdown
Author

@blueorangutan ui

blueorangutan commented Mar 8, 2021

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Mar 8, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4769 (JID-3857)

utchoang marked this pull request as draft March 9, 2021 01:56
GutoVeronezi reviewed Mar 9, 2021
View reviewed changes
Comment thread ui/src/components/view/TreeView.vue Resolved
utchoang marked this pull request as ready for review March 11, 2021 09:04

utchoang commented Mar 11, 2021

Copy link
Copy Markdown
Author

@blueorangutan ui

blueorangutan commented Mar 11, 2021

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

DaanHoogland added this to the 4.16.0.0 milestone Mar 11, 2021
utchoang requested a review from shwstppr March 15, 2021 06:07
utchoang mentioned this pull request Mar 16, 2021
Closed
utchoang changed the base branch from master to 4.15 March 23, 2021 03:55

davidjumani commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented Mar 25, 2021

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

davidjumani commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

@utchoang

 error  in ./src/store/modules/user.js

Module Error (from ./node_modules/thread-loader/dist/cjs.js):

/jenkins/workspace/acs-pr-ui-builder/ui/src/store/modules/user.js
   35:3   error  'HEADER_NOTICES' is defined but never used  no-unused-vars
   90:18  error  'ASYNC_JOB_IDS' is not defined              no-undef
  275:23  error  'ASYNC_JOB_IDS' is not defined              no-undef
  290:34  error  'ASYNC_JOB_IDS' is not defined              no-undef

blueorangutan commented Mar 25, 2021

Copy link
Copy Markdown

UI build: ✖️
(SL-JID-68)

davidjumani commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented Mar 25, 2021

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Mar 25, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4769 (SL-JID-72)

davidjumani approved these changes Mar 26, 2021
View reviewed changes

davidjumani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

yadvr modified the milestones: 4.16.0.0, 4.15.1.0 Apr 5, 2021

yadvr commented Apr 5, 2021

Copy link
Copy Markdown
Member

@utchoang can you fix the conflict?

yadvr commented Apr 5, 2021

Copy link
Copy Markdown
Member

@blueorangutan ui

blueorangutan commented Apr 5, 2021

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Apr 5, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4769 (SL-JID-89)

yadvr merged commit a92b294 into apache:4.15 Apr 6, 2021
utchoang deleted the feature/auto-expand-domain branch April 13, 2021 06:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

GutoVeronezi GutoVeronezi left review comments
davidjumani davidjumani approved these changes
shwstppr Awaiting requested review from shwstppr

Assignees

davidjumani

Labels

component:UI type:bug

Projects

None yet

Milestone

4.15.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL