FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

UI: Moves fetchdata() to the created() by utchoang · Pull Request #4811 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

UI: Moves fetchdata() to the created() - #4811

Merged
yadvr merged 6 commits into
apache:4.15from
utchoang:feature/move-fetchdata-created
Apr 5, 2021
ConversationCommits (6)ChecksFiles changed
Merged

UI: Moves fetchdata() to the created()#4811
yadvr merged 6 commits into
apache:4.15from
utchoang:feature/move-fetchdata-created

Conversation

utchoang commented Mar 15, 2021 •
edited
Loading

Copy link
Copy Markdown

Description

This PR to move fetchData() to created() insteadof mount()

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

utchoang mentioned this pull request Mar 15, 2021
Merged
3 of 12 tasks
utchoang marked this pull request as ready for review March 15, 2021 06:09

utchoang commented Mar 15, 2021

Copy link
Copy Markdown
Author

@blueorangutan ui

blueorangutan commented Mar 15, 2021

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

utchoang requested review from shwstppr and yadvr March 15, 2021 06:34

shwstppr commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

@utchoang will this offer any performance improvement? I hope we are not accessing/manipulating DOM elements in any of the fetchData methods

utchoang commented Mar 15, 2021

Copy link
Copy Markdown
Author

@shwstppr Yes. In apache/cloudstack-primate#719 then move fetchData to created from mounted to reduce wait time for API calls since the data has been created but the page has not yet been rendered

DaanHoogland added this to the 4.15.1.0 milestone Mar 15, 2021
utchoang mentioned this pull request Mar 16, 2021
Closed

yadvr commented Mar 22, 2021

Copy link
Copy Markdown
Member

@utchoang what are the pros and cons of using one vs the other?

utchoang commented Mar 22, 2021

Copy link
Copy Markdown
Author

@rhtyd When the component is initialized, fetching data from the backend at created() will be done without having to wait for the DOM to be mounted or rendered as if it were called on mounted().

davidjumani commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented Mar 25, 2021

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Mar 25, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4811 (SL-JID-63)

davidjumani approved these changes Mar 25, 2021
View reviewed changes

davidjumani left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Did a quick round of testing
Forms appear to load a bit sooner

yadvr commented Mar 29, 2021

Copy link
Copy Markdown
Member

@utchoang can you fix the conflict against latest 4.15 branch

yadvr commented Apr 1, 2021

Copy link
Copy Markdown
Member

@utchoang can you fix the conflict?

yadvr commented Apr 5, 2021

Copy link
Copy Markdown
Member

@blueorangutan ui

blueorangutan commented Apr 5, 2021

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

yadvr approved these changes Apr 5, 2021
View reviewed changes

yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM proxing David's testing/review

yadvr merged commit 4dcd9a2 into apache:4.15 Apr 5, 2021

blueorangutan commented Apr 5, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4811 (SL-JID-88)

utchoang deleted the feature/move-fetchdata-created branch April 5, 2021 09:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
davidjumani davidjumani approved these changes
shwstppr Awaiting requested review from shwstppr

Assignees

davidjumani

Labels

component:UI type:cleanup

Projects

None yet

Milestone

4.15.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL