FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

UI: Edit instance - offer existing Groups by utchoang · Pull Request #4820 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

UI: Edit instance - offer existing Groups - #4820

Merged
yadvr merged 1 commit into
apache:4.15from
utchoang:feature/vm-edit-instance
Mar 18, 2021
ConversationCommits (1)ChecksFiles changed
Merged

UI: Edit instance - offer existing Groups#4820
yadvr merged 1 commit into
apache:4.15from
utchoang:feature/vm-edit-instance

Conversation

utchoang commented Mar 16, 2021 •
edited
Loading

Copy link
Copy Markdown

Description

Edit instance - offer existing Groups
This PR for fix apache/cloudstack-primate#743

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

utchoang mentioned this pull request Mar 16, 2021
Merged
3 of 12 tasks

utchoang commented Mar 16, 2021

Copy link
Copy Markdown
Author

@blueorangutan ui

blueorangutan commented Mar 16, 2021

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

blueorangutan commented Mar 16, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4820 (SL-JID-25)

utchoang marked this pull request as ready for review March 16, 2021 02:57
utchoang requested review from shwstppr and yadvr March 16, 2021 02:57
shwstppr approved these changes Mar 16, 2021
View reviewed changes

shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Lgtm

utchoang mentioned this pull request Mar 16, 2021
Closed
yadvr added this to the 4.15.1.0 milestone Mar 17, 2021

yadvr commented Mar 17, 2021

Copy link
Copy Markdown
Member

@davidjumani @shwstppr was this manually tested?

davidjumani commented Mar 17, 2021

Copy link
Copy Markdown
Contributor

@rhtyd Yes, tested and working

yadvr merged commit 6836a94 into apache:4.15 Mar 18, 2021
utchoang deleted the feature/vm-edit-instance branch March 23, 2021 04:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

shwstppr shwstppr approved these changes
davidjumani davidjumani approved these changes
yadvr Awaiting requested review from yadvr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.15.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL