FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

UI - Fixes - Ctrl+Enter events error by utchoang · Pull Request #5298 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

UI - Fixes - Ctrl+Enter events error - #5298

Merged
nvazquez merged 1 commit into
apache:mainfrom
utchoang:feature/fix-ctrl-enter-event
Aug 11, 2021
ConversationCommits (1)ChecksFiles changed
Merged

UI - Fixes - Ctrl+Enter events error#5298
nvazquez merged 1 commit into
apache:mainfrom
utchoang:feature/fix-ctrl-enter-event

Conversation

utchoang commented Aug 10, 2021 •
edited
Loading

Copy link
Copy Markdown

Description

Related #4766 (comment)
Fix error not found ref in submit button when pressing Ctrl+Enter

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

utchoang commented Aug 10, 2021

Copy link
Copy Markdown
Author

@blueorangutan ui

blueorangutan commented Aug 10, 2021

Copy link
Copy Markdown

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Aug 10, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5298 (SL-JID-497)

nvazquez approved these changes Aug 11, 2021
View reviewed changes

nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM - manually tested

nvazquez added this to the 4.16.0.0 milestone Aug 11, 2021
davidjumani approved these changes Aug 11, 2021
View reviewed changes

davidjumani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Verified, LGTM

nvazquez merged commit 55174d5 into apache:main Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nvazquez nvazquez approved these changes
davidjumani davidjumani approved these changes
shwstppr Awaiting requested review from shwstppr

Assignees

No one assigned

Labels

component:UI type:bug

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL