Repository navigation
UI: show button for dynamic Scaling for VM in case of KVM hypervisor - #5703
Merged
yadvr merged 1 commit intoNov 23, 2021
Merged
yadvr merged 1 commit into
yadvr merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
… since it is supported now
Copy link
Copy Markdown
Contributor
|
LGTM, I did a few manual tests |
Sorry, something went wrong.
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Sorry, something went wrong.
utchoang
approved these changes
Nov 22, 2021
utchoang
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
code LGTM!
Sorry, something went wrong.
Copy link
Copy Markdown
|
UI build: ✔️ |
Sorry, something went wrong.
GutoVeronezi
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
CLGTM
Sorry, something went wrong.
GutoVeronezi
approved these changes
Nov 22, 2021
GutoVeronezi
self-requested a review
November 22, 2021 11:59
yadvr
approved these changes
Nov 23, 2021
mlsorensen
pushed a commit
to mlsorensen/cloudstack
that referenced
this pull request
Dec 20, 2021
… since it is supported now (apache#5703)
This was referenced Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enabled UI button for Dynamic scaling of VM which are on KVM. API support is already here #4878
There are few constraints with KVM support for dynamic scaling like it has to be custom compute offering and need to set maxmemory, but showing it in UI adds value. It fails with an appropriate error when fixed compute offering is used, so it is worth adding to UI. We can also disable the button in such cases but it may confuse users why it is disabled.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?