FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ui: update npm dependencies to latest by yadvr · Pull Request #6091 · apache/cloudstack · GitHub

/ cloudstack Public

ui: update npm dependencies to latest - #6091

Merged
yadvr merged 3 commits into
apache:mainfrom
shapeblue:npm-update-mar22
Mar 15, 2022
ConversationCommits (3)ChecksFiles changed
Merged

ui: update npm dependencies to latest#6091
yadvr merged 3 commits into
apache:mainfrom
shapeblue:npm-update-mar22

Conversation

yadvr commented Mar 10, 2022

Copy link
Copy Markdown
Member

Run commands to update dependencies:

npm outdated
npm update

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

ui: update npm dependencies to latest
4f8c162 
Run commands to update dependencies:

    npm outdated
    npm update

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr commented Mar 10, 2022

Copy link
Copy Markdown
Member Author

@blueorangutan ui

blueorangutan commented Mar 10, 2022

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Mar 10, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6091 (SL-JID-1240)

yadvr commented Mar 10, 2022

Copy link
Copy Markdown
Member Author

@blueorangutan package

blueorangutan commented Mar 10, 2022

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Mar 10, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2835

yadvr commented Mar 13, 2022

Copy link
Copy Markdown
Member Author

@blueorangutan ui
@blueorangutan package

blueorangutan commented Mar 13, 2022

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Mar 13, 2022

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Mar 13, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6091 (SL-JID-1250)

blueorangutan commented Mar 13, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2857

utchoang approved these changes Mar 14, 2022
View reviewed changes

utchoang left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

davidjumani approved these changes Mar 14, 2022
View reviewed changes

davidjumani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

CLGTM. Will run tests of this along with Vue3

davidjumani mentioned this pull request Mar 14, 2022
Closed

yadvr commented Mar 14, 2022

Copy link
Copy Markdown
Member Author

@davidjumani great, agree. Let's merge this only after running some manual tests.

davidjumani mentioned this pull request Mar 14, 2022
Closed
davidjumani approved these changes Mar 15, 2022
View reviewed changes

davidjumani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ran basic tests, Good to merge. Can continue testing once merged

yadvr added this to the 4.17.0.0 milestone Mar 15, 2022
yadvr merged commit b296546 into apache:main Mar 15, 2022
yadvr deleted the npm-update-mar22 branch March 15, 2022 09:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

davidjumani davidjumani approved these changes
sureshanaparti sureshanaparti approved these changes
utchoang utchoang approved these changes
nvazquez Awaiting requested review from nvazquez

Assignees

No one assigned

Labels

component:UI type:enhancement

Projects

No open projects
Apache CloudStack 4.17.0
Status: Todo

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL