FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix listofferings failing for usrs and failin travis tests by davidjumani · Pull Request #6125 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Fix listofferings failing for usrs and failin travis tests - #6125

Closed
davidjumani wants to merge 2 commits into
apache:mainfrom
shapeblue:fix-list-by-id
ConversationCommits (2)ChecksFiles changed
Closed

Fix listofferings failing for usrs and failin travis tests#6125
davidjumani wants to merge 2 commits into
apache:mainfrom
shapeblue:fix-list-by-id

Conversation

davidjumani commented Mar 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR Fixes the following :

  • Sets isrecursive=false for users when listall=true by default to prevent any permission issues when listing resources as a user
  • Failing travis tests

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

$ nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=setup/dev/advanced.cfg  -s -a tags=mine --hypervisor=simulator test/integration/component/test_acl_listvm.py

=== TestName: test_listVM_by_id_as_domainadmin_ownedbyusersinsubdomain2 | Status : SUCCESS ===

=== TestName: test_listVM_by_id_as_domainadmin_ownedbyusersnotindomain | Status : SUCCESS ===



$ nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=setup/dev/advanced.cfg  -s -a tags=mine --hypervisor=simulator test/integration/component/test_acl_listsnapshot.py

=== TestName: test_listSnapshot_by_id_as_domainadmin_ownedbyusersinsubdomain2 | Status : SUCCESS ===

=== TestName: test_listSnapshot_by_id_as_domainadmin_ownedbyusersnotindomain | Status : SUCCESS ===

davidjumani mentioned this pull request Mar 16, 2022
Closed
1 of 5 tasks

davidjumani commented Mar 16, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Mar 16, 2022

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Mar 16, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2900

davidjumani commented Mar 16, 2022

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

blueorangutan commented Mar 16, 2022

Copy link
Copy Markdown

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

nvazquez added this to the 4.17.0.0 milestone Mar 16, 2022

davidjumani commented Mar 16, 2022

Copy link
Copy Markdown
Contributor Author

Closing in favour of #6126

yadvr removed this from the 4.17.0.0 milestone Mar 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Severity:Major type:bug

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL