Deprecated changeServiceForVirtualMachine API and replaced all the oc… by harikrishna-patnala · Pull Request #6540 · apache/cloudstack · GitHub

Description

This PR fixes issue #6150 to deprecate changeServiceForVirtualMachine API. Going forward the idea is to use scaleVirtualMachine API for both stopped and running VMs which we are already doing from UI.

I've also changed the API in all the tests to use scaleVirtualMachine API.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

BLOCKER
Critical
Major
Minor
Trivial

Screenshots (if appropriate):

How Has This Been Tested?

…curences in the tests with scaleVirtualMachine

@blueorangutan package

@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3726

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

No Coverage information
0.0% Duplication

@blueorangutan test matrix

@harikrishna-patnala a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian Build Failed (tid-4452)

@blueorangutan test matrix

@harikrishna-patnala a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

changes LGTM

Trillian test result (tid-4453)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38777 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6540-t4453-xenserver-71.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

Trillian test result (tid-4451)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40686 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6540-t4451-kvm-centos7.zip
Smoke tests completed. 94 look OK, 4 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_primary_storage_disabled_host	Error	0.65	test_primary_storage.py
test_01_primary_storage_nfs	Error	0.10	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	Error	0.19	test_primary_storage.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	38.02	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	Failure	113.15	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	44.19	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	42.15	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	Error	132.21	test_kubernetes_clusters.py
test_01_secure_vm_migration	Error	160.53	test_vm_life_cycle.py
test_02_unsecure_vm_migration	Error	276.19	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	Error	142.92	test_vm_life_cycle.py
test_08_migrate_vm	Error	43.78	test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance	Error	305.81	test_hostha_kvm.py

Trillian test result (tid-4454)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45836 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6540-t4454-kvm-centos7.zip
Smoke tests completed. 97 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	613.78	test_kubernetes_clusters.py

Trillian test result (tid-4450)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49549 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6540-t4450-xenserver-71.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

Trillian test result (tid-4455)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 54107 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6540-t4455-vmware-65u2.zip
Smoke tests completed. 85 look OK, 13 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestListIdsParams>:setup	Error	0.00	test_list_ids_parameter.py
ContextSuite context=TestResetVmOnReboot>:setup	Error	0.00	test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup	Error	0.00	test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup	Error	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	Error	0.00	test_router_dhcphosts.py
test_01_import_storage_policies	Error	0.00	test_storage_policy.py
ContextSuite context=TestRouterDns>:setup	Error	0.00	test_router_dns.py
ContextSuite context=TestVAppsVM>:setup	Error	1.59	test_vm_life_cycle.py
ContextSuite context=TestRouterDnsService>:setup	Error	0.00	test_router_dnsservice.py
test_01_create_template	Error	71.20	test_templates.py
test_CreateTemplateWithDuplicateName	Error	126.69	test_templates.py
test_02_create_template_with_checksum_sha1	Error	65.42	test_templates.py
test_03_create_template_with_checksum_sha256	Error	65.46	test_templates.py
test_04_create_template_with_checksum_md5	Error	65.43	test_templates.py
test_05_create_template_with_no_checksum	Error	65.50	test_templates.py
test_03_delete_template	Error	453.49	test_templates.py
test_04_extract_template	Error	1.10	test_templates.py
test_09_list_templates_download_details	Failure	0.07	test_templates.py
ContextSuite context=TestInternalLb>:setup	Error	0.00	test_internal_lb.py
ContextSuite context=TestRouterServices>:setup	Error	0.00	test_routers.py
test_01_isolate_network_FW_PF_default_routes_egress_true	Error	0.23	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	Error	0.20	test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup	Error	1.48	test_routers_network_ops.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	Failure	555.86	test_vpc_redundant.py

@blueorangutan test centos7 vmware-65u2

@harikrishna-patnala a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

clgtm
we should go through the test files and assess whether all tests make sense/are valid. test_deploy_vgpu_vm seems excesive in comparison to its niche. The minimal change is certainly in line with the scope of this PR though!

clgtm we should go through the test files and assess whether all tests make sense/are valid. test_deploy_vgpu_vm seems excesive in comparison to its niche. The minimal change is certainly in line with the scope of this PR though!

Yes @DaanHoogland, I've gone through them and made the changes in the test files. By code and usage both APIs look similar. Let's wait for the smoke test results.

clgtm we should go through the test files and assess whether all tests make sense/are valid. test_deploy_vgpu_vm seems excesive in comparison to its niche. The minimal change is certainly in line with the scope of this PR though!

Yes @DaanHoogland, I've gone through them and made the changes in the test files. By code and usage both APIs look similar. Let's wait for the smoke test results.

Don't worry @harikrishna-patnala I do not mean for this PR to change but just to put a mental note to us all.

Trillian test result (tid-4456)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46852 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6540-t4456-vmware-65u2.zip
Smoke tests completed. 96 look OK, 2 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	Failure	0.03	test_ssvm.py
test_04_cpvm_internals	Failure	0.03	test_ssvm.py
test_06_stop_cpvm	Failure	0.03	test_ssvm.py
test_08_reboot_cpvm	Failure	0.04	test_ssvm.py
test_10_reboot_cpvm_forced	Failure	0.03	test_ssvm.py
test_12_destroy_cpvm	Error	2308.66	test_ssvm.py
test_08_upgrade_kubernetes_ha_cluster	Failure	715.18	test_kubernetes_clusters.py

@blueorangutan test centos7 vmware-65u2

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@blueorangutan test centos7 vmware-67u3

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

Trillian test result (tid-4464)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43111 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6540-t4464-vmware-65u2.zip
Smoke tests completed. 97 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	728.87	test_kubernetes_clusters.py

Trillian test result (tid-4469)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40609 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6540-t4469-vmware-67u3.zip
Smoke tests completed. 98 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

Deprecated changeServiceForVirtualMachine API and replaced all the oc…

3fb95a0

…curences in the tests with scaleVirtualMachine

boring-cyborg Bot added component:api component:integration-test component:marvin Python Warning... Python code Ahead! labels Jul 7, 2022

harikrishna-patnala added this to the 4.18.0.0 milestone Jul 7, 2022

yadvr approved these changes Jul 7, 2022

View reviewed changes

sureshanaparti approved these changes Jul 7, 2022

View reviewed changes

DaanHoogland approved these changes Jul 8, 2022

View reviewed changes

yadvr merged commit 65b0bcb into apache:main Jul 9, 2022

yadvr mentioned this pull request Jul 9, 2022

Cleanup: Remove redundant API to change service offering for VMs #6150

Closed

Deprecated changeServiceForVirtualMachine API and replaced all the oc… by harikrishna-patnala · Pull Request #6540 · apache/cloudstack · GitHub

Repository navigation

Deprecated changeServiceForVirtualMachine API and replaced all the oc… - #6540

Deprecated changeServiceForVirtualMachine API and replaced all the oc…#6540yadvr merged 1 commit intoapache:mainapache/cloudstack:mainfrom shapeblue:DeprecateChangeServiceForVirtualMachineAPIshapeblue/cloudstack:DeprecateChangeServiceForVirtualMachineAPICopy head branch name to clipboard

Conversation

harikrishna-patnala commented Jul 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

harikrishna-patnala commented Jul 7, 2022

Uh oh!

blueorangutan commented Jul 7, 2022

Uh oh!

blueorangutan commented Jul 7, 2022

Uh oh!

sonarqubecloud Bot commented Jul 7, 2022

Uh oh!

harikrishna-patnala commented Jul 7, 2022

Uh oh!

blueorangutan commented Jul 7, 2022

Uh oh!

blueorangutan commented Jul 7, 2022

Uh oh!

harikrishna-patnala commented Jul 7, 2022

Uh oh!

blueorangutan commented Jul 7, 2022

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jul 7, 2022

Uh oh!

blueorangutan commented Jul 7, 2022

Uh oh!

blueorangutan commented Jul 8, 2022

Uh oh!

blueorangutan commented Jul 8, 2022

Uh oh!

blueorangutan commented Jul 8, 2022

Uh oh!

harikrishna-patnala commented Jul 8, 2022

Uh oh!

blueorangutan commented Jul 8, 2022

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala commented Jul 8, 2022

Uh oh!

DaanHoogland commented Jul 8, 2022

Uh oh!

blueorangutan commented Jul 8, 2022

Uh oh!

yadvr commented Jul 9, 2022

Uh oh!

blueorangutan commented Jul 9, 2022

Uh oh!

yadvr commented Jul 9, 2022

Uh oh!

blueorangutan commented Jul 9, 2022

Uh oh!

blueorangutan commented Jul 9, 2022

Uh oh!

blueorangutan commented Jul 10, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Deprecated changeServiceForVirtualMachine API and replaced all the oc…#6540
yadvr merged 1 commit into
apache:mainfrom
shapeblue:DeprecateChangeServiceForVirtualMachineAPI

harikrishna-patnala commented Jul 7, 2022 •
edited
Loading