FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Proposal for an improved CglibThrowableRenderer by rafaelweingartner · Pull Request #762 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Proposal for an improved CglibThrowableRenderer - #762

Merged
asfgit merged 2 commits into
apache:masterfrom
rafaelweingartner:cglibThrowableRenderer
Sep 1, 2015
ConversationCommits (2)ChecksFiles changed
Merged

Proposal for an improved CglibThrowableRenderer#762
asfgit merged 2 commits into
apache:masterfrom
rafaelweingartner:cglibThrowableRenderer

Conversation

rafaelweingartner commented Aug 29, 2015

Copy link
Copy Markdown
Member

Following our discussions on mailing list, here is a PR with a proposal for an improvement on “CglibThrowableRenderer”. We would still have to define a number to limit the stack traces of causes (I randomly chose 3, just to get the code running). The test case is also not good in my opinion, but I ran out of ideas (waiting for suggestions on that).

asfbot commented Aug 29, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #445 FAILURE
Looks like there's a problem with this pull request

asfbot commented Aug 29, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #446 SUCCESS
This pull request looks good

asfbot commented Aug 29, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #447 SUCCESS
This pull request looks good

Proposal for an improved CglibThrowableRenderer
89bac52 
Apache license
Shame on me...

Fix test to pass on travis build

asfbot commented Aug 30, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #378 UNSTABLE
Looks like there's a problem with this pull request

asfbot commented Aug 30, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #379 UNSTABLE
Looks like there's a problem with this pull request

asfbot commented Aug 30, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #380 ABORTED

asfbot commented Aug 30, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #448 SUCCESS
This pull request looks good

asfbot commented Aug 30, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #381 SUCCESS
This pull request looks good

DaanHoogland commented Aug 30, 2015

Copy link
Copy Markdown
Contributor

LGTM, reviewing this I finally understand why we have a custom renderer at all. The travis failing checks are unrelated timeouts.

rafaelweingartner commented Aug 30, 2015

Copy link
Copy Markdown
Member Author

Does anyone else have some ideas on how to test that code?
I am not comfortable with the test I coded, the test feels shallow.

asfbot commented Aug 31, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #453 SUCCESS
This pull request looks good

asfbot commented Aug 31, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #386 UNSTABLE
Looks like there's a problem with this pull request

rafaelweingartner commented Aug 31, 2015

Copy link
Copy Markdown
Member Author

The tests that have failed do not seem to be related to the code that was changed.

karuturi mentioned this pull request Sep 1, 2015
Closed

karuturi commented Sep 1, 2015

Copy link
Copy Markdown
Member

@rafaelweingartner I see windows line endings in the new test file. Can you fix that please?
Other than that, LGTM. once thats fixed I will merge

karuturi commented Sep 1, 2015

Copy link
Copy Markdown
Member

since this fixes slow build, I am going to merge this PR and push another commit for line endings fix.

asfgit merged commit b49d681 into apache:master Sep 1, 2015
asfgit pushed a commit that referenced this pull request Sep 1, 2015
Merge pull request #762 from rafaelweingartner/cglibThrowableRenderer
e8979c0 
Proposal for an improved CglibThrowableRendererFollowing our discussions on mailing list, here is a PR with a proposal for an improvement on CglibThrowableRenderer. We would still have to define a number to limit the stack traces of causes (I randomly chose 3, just to get the code running). The test case is also not good in my opinion, but I ran out of ideas (waiting for suggestions on that).

* pr/762:
  Changed the test case to test each of the log traces in the array list.
  Proposal for an improved CglibThrowableRenderer

Signed-off-by: Rajani Karuturi <rajani.karuturi@citrix.com>
asfgit pushed a commit that referenced this pull request Sep 1, 2015
Fixing line endings in the new file introduced in PR #762 merged thro…
22c78ed 
…ugh commit e8979c0

rafaelweingartner commented Sep 1, 2015

Copy link
Copy Markdown
Member Author

@karuturi, Sorry for the windows line endings (did you see that on log files? I was not able to see anything there). Sometimes I jump between OS and forget that I am coding from a Windows machine, instead of my usual Ubuntu.

BTW: I think we are in very different time zones, I just woke up. Thanks for the windows line fix.

karuturi commented Sep 1, 2015

Copy link
Copy Markdown
Member

cat -v filename will show you line endings.
I figured the timezone issue. didnt want to wait for another day with broken build. hence pushed it.
The recent build passed. Thanks :)

rafaelweingartner commented Sep 1, 2015

Copy link
Copy Markdown
Member Author

With your comments, I fixed my Eclipse configuration on my Windows
environment, now I am using UNIX lines for ACS on windows.

On Tue, Sep 1, 2015 at 9:33 AM, Rajani Karuturi notifications@github.com
wrote:

cat -v filename will show you line endings.
I figured the timezone issue. didnt want to wait for another day with
broken build. hence pushed it.
The recent build passed. Thanks :)

—
Reply to this email directly or view it on GitHub
#762 (comment).

Rafael Weingärtner

rafaelweingartner mentioned this pull request Sep 15, 2015
Closed
yadvr pushed a commit that referenced this pull request Jan 20, 2021
vm: FIX - Add dropdown select IP for network type is Shared (#762)
7eea84f 
* vm: add dropdown select IP for network type is Shared

* remove function not use

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
JoaoJandre pushed a commit to scclouds/cloudstack that referenced this pull request Nov 24, 2022
Merge branch 'vmware-change-validation-of-network-owners-in-import' i…
052adb6 
…nto '4.16.0.0-scclouds'

[VMware] Alterar validação sobre donos da rede ao importar VMs

Closes apache#762

See merge request scclouds/scclouds!307
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL