FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Details on add guest os optional by DaanHoogland · Pull Request #7812 · apache/cloudstack · GitHub

/ cloudstack Public

Details on add guest os optional - #7812

Merged
DaanHoogland merged 1 commit into
apache:4.18from
shapeblue:detailsOnAddGuestOs
Aug 4, 2023
ConversationCommits (1)ChecksFiles changed
Merged

Details on add guest os optional#7812
DaanHoogland merged 1 commit into
apache:4.18from
shapeblue:detailsOnAddGuestOs

Conversation

DaanHoogland commented Aug 3, 2023

Copy link
Copy Markdown
Contributor

Description

This PR fixes a issue reported in the user mail list: https://lists.apache.org/thread/clsoyz3kgp47ppbhtqp8m0o2fkczqrmk

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

apache deleted a comment from blueorangutan Aug 3, 2023

DaanHoogland commented Aug 3, 2023

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Aug 3, 2023

Copy link
Copy Markdown

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Aug 3, 2023

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6650

codecov Bot commented Aug 3, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7812 (a2e5b1a) into 4.18 (c86684f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.18    #7812      +/-   ##
============================================
- Coverage     13.02%   13.02%   -0.01%     
+ Complexity     9031     9029       -2     
============================================
  Files          2720     2720              
  Lines        257010   257010              
  Branches      40083    40083              
============================================
- Hits          33472    33467       -5     
- Misses       219336   219342       +6     
+ Partials       4202     4201       -1

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

DaanHoogland commented Aug 3, 2023

Copy link
Copy Markdown
Contributor Author

I don't think this will be touched by any smoke tests

BryanMLima approved these changes Aug 3, 2023
View reviewed changes

BryanMLima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, already manually tested this change with PR #6979.

harikrishna-patnala approved these changes Aug 4, 2023
View reviewed changes

harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

code LGTM

DaanHoogland merged commit 6b21825 into apache:4.18 Aug 4, 2023
DaanHoogland deleted the detailsOnAddGuestOs branch August 4, 2023 06:44
DaanHoogland added this to the 4.18.1.0 milestone Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

harikrishna-patnala harikrishna-patnala approved these changes
BryanMLima BryanMLima approved these changes

Assignees

No one assigned

Labels

component:api

Projects

None yet

Milestone

4.18.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL