| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Sorry, something went wrong.
Codecov ReportAttention: 1 lines in your changes are missing coverage. Please review.
@@ Coverage Diff @@
## main #8433 +/- ##
============================================
- Coverage 30.79% 29.01% -1.79%
+ Complexity 33979 31749 -2230
============================================
Files 5341 5341
Lines 374870 374870
Branches 54521 54521
============================================
- Hits 115449 108752 -6697
- Misses 244177 251549 +7372
+ Partials 15244 14569 -675
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
There was a problem hiding this comment.
Code LGTM
Sorry, something went wrong.
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8190 |
Sorry, something went wrong.
There was a problem hiding this comment.
code LGTM
Sorry, something went wrong.
There was a problem hiding this comment.
clgtm, ...
Sorry, something went wrong.
|
@blueorangutan test alma8 kvm-alma8 keepEnv |
Sorry, something went wrong.
|
@DaanHoogland a [SL] Trillian-Jenkins test job (alma8 mgmt + kvm-alma8) has been kicked to run smoke tests |
Sorry, something went wrong.
|
Tests results from the backend look okay, 07:09:37 msg: {"body": "<b>[SF] Trillian test result (tid-8723)</b>
Environment: kvm-alma8 (x2), Advanced Networking with Mgmt server a8
Total time taken: 51637 seconds
Marvin logs: [https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8433-t8723-kvm-alma8.zip
Smoke](https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8433-t8723-kvm-alma8.zip
Smoke) tests completed. 120 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 85.62 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 52.99 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 47.20 | test_vm_life_cycle.py"}
|
Sorry, something went wrong.
|
@nvazquez unmanage looks ok, but re-manage does not work with an error about the root size. I suppose that is a different bug/issue? |
Sorry, something went wrong.
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Sorry, something went wrong.
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8230 |
Sorry, something went wrong.
|
@DaanHoogland we've checked the issue happened for VMs created using a small sized template like macchinina: 2024-01-08 12:48:32,456 INFO [c.c.v.UserVmManagerImpl] (API-Job-Executor-36:ctx-cd93fee3 job-5073 ctx-44a5da1a) (logid:548e0c0e) VM cannot be configured to
be dynamically scalable if any of the service offering's dynamic scaling property, template's dynamic scaling property or global setting is false
2024-01-08 12:48:32,458 ERROR [c.c.v.UserVmManagerImpl] (API-Job-Executor-36:ctx-cd93fee3 job-5073 ctx-44a5da1a) (logid:548e0c0e) Unsupported: rootdisksize override (0 GB) is smaller than template size (50.00 MB) 52428800
2024-01-08 12:48:32,464 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (API-Job-Executor-36:ctx-cd93fee3 job-5073) (logid:548e0c0e) Complete async job-5073, jobStatus: FAILED, resultCode: 431, result: org.apache.cloudstack.api.response.ExceptionResponse/null/{"uuidList":[],"errorcode":"431","errortext":"Unsupported: rootdisksize override (0 GB) is smaller than template size (50.00 MB) 52428800"}
This looks like a rounding issue we can address on a separate PR |
Sorry, something went wrong.
|
@nvazquez a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Sorry, something went wrong.
|
[SF] Trillian test result (tid-8762)
|
Sorry, something went wrong.
|
Merging this based on tests. GH CI failures are codecov related |
Sorry, something went wrong.
This PR fixes KVM manage/unmanage functionality on 4.19.0 RC1 - was introduced on apache#7976 but the latest merge commits on the PR removed the execution for KVM
This PR fixes import unmanaged instances on KVM basic zones, on top of apache#8433 Fixes: apache#8439: point 1
There are a lot of test failures due to test_vm_life_cycle.py in multiple PRs due to host not available for migration of VMs. #8438 (comment) #8433 (comment) #7344 (comment) While debugging I noticed that the hosts get stuck in Connecting state because MS is waiting for a response of the ReadyCommand from the agent. Since we take a lock on connection and disconnection, restarting the agent doesn't work. To fix this, we have to restart the MS or wait for ~1 hour (default timeout). On the agent side, it gets stuck waiting for a response from the Script execution. To reproduce, run smoke/test_vm_life_cycle.py (TestSecuredVmMigration test class to be specific). Once the tests are complete, you will notice that some hosts are stuck in Connecting state. And restarting the agent fails due to the named lock. Locks on DB can be checked using the below query. SELECT * FROM performance_schema.metadata_locks INNER JOIN performance_schema.threads ON THREAD_ID = OWNER_THREAD_ID WHERE PROCESSLIST_ID <> CONNECTION_ID() \G; This PR adds a wait for the ready command and a timeout to the Script execution to ensure that the thread doesn't get stuck and the named lock from database is released.
* Fix host stuck in connecting state (apache#8502) There are a lot of test failures due to test_vm_life_cycle.py in multiple PRs due to host not available for migration of VMs. apache#8438 (comment) apache#8433 (comment) apache#7344 (comment) While debugging I noticed that the hosts get stuck in Connecting state because MS is waiting for a response of the ReadyCommand from the agent. Since we take a lock on connection and disconnection, restarting the agent doesn't work. To fix this, we have to restart the MS or wait for ~1 hour (default timeout). On the agent side, it gets stuck waiting for a response from the Script execution. To reproduce, run smoke/test_vm_life_cycle.py (TestSecuredVmMigration test class to be specific). Once the tests are complete, you will notice that some hosts are stuck in Connecting state. And restarting the agent fails due to the named lock. Locks on DB can be checked using the below query. SELECT * FROM performance_schema.metadata_locks INNER JOIN performance_schema.threads ON THREAD_ID = OWNER_THREAD_ID WHERE PROCESSLIST_ID <> CONNECTION_ID() \G; This PR adds a wait for the ready command and a timeout to the Script execution to ensure that the thread doesn't get stuck and the named lock from database is released. * Externalise a few timeouts & fix timeout for hostSupportsUefi in libvirt ready command wrapper (apache#8547) This PR fixes bug introduced in apache#8502. Timeout for script execution was set to 60 ms instead of 60s which resulted in host not getting UEFI enabled. This is a blocker for 4.19 release. We do this by introducing a new agent parameter `agent.script.timeout` (default - 60 seconds) to use as a timeout for the script checking host's UEFI status. We also externalize the timeout for the ReadyCommand by introducing a new global setting `ready.command.wait` (default - 60 seconds). For ModifyStoragePoolCommand, we don't externalize the timeout to avoid confusion for the user. Since, the required timeout can vary depending on the provider in use and we are only setting the wait for default host listener for now. Instead, we reuse the global `wait` setting by dividing it by `5` making the default value of 6 minutes (1800/5 = 360s) for ModifyStoragePoolCommand. Note: the actual time, the MS waits is twice the wait set for a Command. Check reference code below. https://github.com/apache/cloudstack/blob/19250403e645c76f60b17aa4aeb4dc915f5ca206/engine/orchestration/src/main/java/com/cloud/agent/manager/AgentAttache.java#L406-L442 * fixup
| Back | FazBrowse Home | New Git URL |
Description
This PR fixes KVM manage/unmanage functionality on 4.19.0 RC1 - was introduced on #7976 but the latest merge commits on the PR removed the execution for KVM
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?