FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix allocation of VMs with multiple clusters by BryanMLima · Pull Request #8611 · apache/cloudstack · GitHub

/ cloudstack Public

Fix allocation of VMs with multiple clusters - #8611

Merged
borisstoyanov merged 2 commits into
apache:4.19from
scclouds:fix-allocation-for-multiple-clusters
Jun 14, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Fix allocation of VMs with multiple clusters#8611
borisstoyanov merged 2 commits into
apache:4.19from
scclouds:fix-allocation-for-multiple-clusters

Conversation

BryanMLima commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

Description

This PR fixes a scenario where if the first cluster verified by ACS does not have any compatible hosts, an exception is thrown, ignoring the verification of possible compatible hosts in other clusters.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  • Cluster 1: Host A
  • Cluster 2: Host B

Using the environment above, I added the flexible host tag false to Host A, and tried to deploy a VM; which would always result on an incompatible host for Cluster 1. Prior to this patch, the CloudRuntimeException is thrown with the message No suitable host found for vm [...]. and Host B is not verified.

After applying this patch, the message No suitable host found for VM [%s] in %s. is still logged, however, Host B is verified for compatibility and the VM is deployed as expected.

How did you try to break this feature and the system with this change?

weizhouapache commented Feb 5, 2024

Copy link
Copy Markdown
Member

@BryanMLima
target to main or 4.18/4.19 ?

BryanMLima force-pushed the fix-allocation-for-multiple-clusters branch from edbb12a to 901cf2d Compare February 5, 2024 14:04
BryanMLima changed the base branch from main to 4.19 February 5, 2024 14:04

BryanMLima commented Feb 5, 2024

Copy link
Copy Markdown
Contributor Author

@BryanMLima target to main or 4.18/4.19 ?

Thanks, I rebased to 4.19 as the problem arose from PR #7489.

BryanMLima added this to the 4.19.1.0 milestone Feb 5, 2024

BryanMLima commented Feb 5, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Feb 5, 2024

Copy link
Copy Markdown

@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov Bot commented Feb 5, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c795547) 20.99% compared to head (710c848) 4.38%.
Report is 16 commits behind head on 4.19.

❗ Current head 710c848 differs from pull request most recent head 6676a4b. Consider uploading reports for the commit 6676a4b to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #8611       +/-   ##
============================================
- Coverage     20.99%   4.38%   -16.62%     
============================================
  Files          4849     361     -4488     
  Lines        324441   28700   -295741     
  Branches      45573    5004    -40569     
============================================
- Hits          68121    1258    -66863     
+ Misses       246563   27303   -219260     
+ Partials       9757     139     -9618
Flag Coverage Δ
simulator-marvin-tests ?
uitests 4.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan commented Feb 6, 2024

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

BryanMLima force-pushed the fix-allocation-for-multiple-clusters branch from 710c848 to 6676a4b Compare February 8, 2024 14:10
DaanHoogland approved these changes Feb 9, 2024
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

yadvr approved these changes Feb 16, 2024
View reviewed changes

yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM - but this need some (manual) testing

BryanMLima commented Feb 29, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Feb 29, 2024

Copy link
Copy Markdown

@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Feb 29, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8820

DaanHoogland commented Mar 4, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented Mar 4, 2024

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Mar 4, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-9375)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47115 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8611-t9375-kvm-centos7.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_trigger_shutdown Failure 336.69 test_safe_shutdown.py

BryanMLima requested a review from JoaoJandre March 11, 2024 13:47
JoaoJandre approved these changes Mar 11, 2024
View reviewed changes

JoaoJandre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

CLGTM, didn't test it

BryanMLima commented May 22, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented May 22, 2024

Copy link
Copy Markdown

@BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented May 22, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9676

borisstoyanov self-assigned this Jun 14, 2024
borisstoyanov approved these changes Jun 14, 2024
View reviewed changes

borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, manually checked the changes.

borisstoyanov merged commit 00fe25a into apache:4.19 Jun 14, 2024
borisstoyanov removed their assignment Jun 14, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 20, 2024
Fix allocation of VMs with multiple clusters (apache#8611)
d544c95 
* Fix allocation of VMs with multiple clusters

* Readd debug guard
This was referenced Mar 21, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
DaanHoogland DaanHoogland approved these changes
borisstoyanov borisstoyanov approved these changes
JoaoJandre JoaoJandre approved these changes

Assignees

No one assigned

Labels

component:agent component:api component:build component:integration component:management-server

Projects

No open projects
Apache CloudStack 4.19.1
Status: Done

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL