FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

kvm: support Rocky/RHEL/OL/Alma in the same cluster by weizhouapache · Pull Request #8641 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

kvm: support Rocky/RHEL/OL/Alma in the same cluster - #8641

Merged
yadvr merged 2 commits into
apache:4.18from
weizhouapache:4.18-kvm-compatible-oses
Jun 24, 2024
ConversationCommits (2)ChecksFiles changed
Merged

kvm: support Rocky/RHEL/OL/Alma in the same cluster#8641
yadvr merged 2 commits into
apache:4.18from
weizhouapache:4.18-kvm-compatible-oses

Conversation

weizhouapache commented Feb 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR fixes #8604

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache commented Feb 12, 2024

Copy link
Copy Markdown
Member Author

@DaanHoogland @rohityadavcloud
how about this ?

weizhouapache added this to the 4.18.2.0 milestone Feb 12, 2024

weizhouapache commented Feb 12, 2024

Copy link
Copy Markdown
Member Author

@blueorangutan package

blueorangutan commented Feb 12, 2024

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov Bot commented Feb 12, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 13.16%. Comparing base (672206c) to head (865c356).
Report is 11 commits behind head on 4.18.

Files Patch % Lines
...rvisor/kvm/discoverer/LibvirtServerDiscoverer.java 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.18    #8641   +/-   ##
=========================================
  Coverage     13.16%   13.16%           
- Complexity     9200     9205    +5     
=========================================
  Files          2724     2724           
  Lines        258109   258116    +7     
  Branches      40228    40229    +1     
=========================================
+ Hits          33971    33986   +15     
+ Misses       219835   219823   -12     
- Partials       4303     4307    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan commented Feb 12, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8630

weizhouapache linked an issue Feb 12, 2024 that may be closed by this pull request
After upgrade from 4.18.0 to 4.18.1 cloudstack-agent not starting #8604
Closed
weizhouapache force-pushed the 4.18-kvm-compatible-oses branch from 9620fc4 to 865c356 Compare February 12, 2024 16:16

yadvr commented Feb 13, 2024

Copy link
Copy Markdown
Member

One remark - we shouldn't allow mixing different major versions of any of these EL distros though. (so OL8 with Alma8 is okay, but not OL7 with Alma8)

DaanHoogland approved these changes Feb 13, 2024
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This code looks good to me @weizhouapache . I've been looking to see if we can guarantee what @rohityadavcloud states, as it makes sense. However, whether or not, that part of the logic doesn't change here, CLGTM. (and unit tests added!)

weizhouapache commented Feb 13, 2024

Copy link
Copy Markdown
Member Author

This code looks good to me @weizhouapache . I've been looking to see if we can guarantee what @rohityadavcloud states, as it makes sense. However, whether or not, that part of the logic doesn't change here, CLGTM. (and unit tests added!)

agree @rohityadavcloud @DaanHoogland

Currently it is supported to put different version of same OS distribution in the same cluster, for example ol8 and ol9, rocky8 and rocky9. It might be useful for users to upgrade the OSes.
Normally the vm migration from older QEMU (e.g in rocky8) to newer QEMU (e.g. in rocky9) should work.

weizhouapache marked this pull request as ready for review February 13, 2024 09:02

yadvr commented Feb 16, 2024

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented Feb 16, 2024

Copy link
Copy Markdown

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Feb 16, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8679

DaanHoogland commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented Feb 16, 2024

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Feb 17, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-9258)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42168 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8641-t9258-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

JoaoJandre modified the milestones: 4.18.2.0, 4.18.3 Mar 21, 2024

weizhouapache commented Apr 24, 2024

Copy link
Copy Markdown
Member Author

@blueorangutan package

blueorangutan commented Apr 24, 2024

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Apr 24, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9388

yadvr modified the milestones: 4.18.3, 4.19.1.0 Apr 30, 2024

yadvr commented Apr 30, 2024

Copy link
Copy Markdown
Member

@blueorangutan test

blueorangutan commented Apr 30, 2024

Copy link
Copy Markdown

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented May 1, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-10098)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46380 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8641-t10098-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

sureshanaparti approved these changes Jun 14, 2024
View reviewed changes

sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

yadvr merged commit fcfa371 into apache:4.18 Jun 24, 2024
yadvr mentioned this pull request Jun 24, 2024
Closed
DaanHoogland deleted the 4.18-kvm-compatible-oses branch June 24, 2024 18:39
yashi4engg mentioned this pull request Jul 1, 2024
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 2, 2024
kvm: support Rocky/RHEL/OL/Alma in the same cluster (apache#8641)
9c0c8f8 
* kvm: support Rocky/RHEL/OL/Alma in the same cluster

* Update PR#8641: add unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
DaanHoogland DaanHoogland approved these changes
sureshanaparti sureshanaparti approved these changes

Assignees

No one assigned

Labels

component:kvm Severity:Minor

Projects

No open projects
Apache CloudStack 4.19.1
Status: Done

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

After upgrade from 4.18.0 to 4.18.1 cloudstack-agent not starting

6 participants

Back | FazBrowse Home | New Git URL