FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Change iops on offering change by vishesh92 · Pull Request #8872 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Change iops on offering change - #8872

Merged
yadvr merged 5 commits into
apache:4.19from
shapeblue:change-iops-on-offering-change
Apr 11, 2024
ConversationCommits (5)ChecksFiles changed
Merged

Change iops on offering change#8872
yadvr merged 5 commits into
apache:4.19from
shapeblue:change-iops-on-offering-change

Conversation

vishesh92 commented Apr 2, 2024

Copy link
Copy Markdown
Member

Description

This PR allows changing of IOPS on changing of disk offering via changeOfferingForVolume command.
As of now changing disk offering does change the size of the disk but doesn't update the IOPS for the volume.

This PR also updates the IOPS to unlimited while copying the template to the volume to speed up start up of a VM.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested with ScaleIO/powerflex.

  1. Create two disk offerings with different IOPS
  2. Launch a VM with the one of the above disk offerings
  3. Check IOPS for the volume in powerflex dashboard
  4. Change the offering for the volume
  5. Recheck IOPS for the volume in powerflex dashboard

How did you try to break this feature and the system with this change?

vishesh92 commented Apr 2, 2024

Copy link
Copy Markdown
Member Author

@blueorangutan package

blueorangutan commented Apr 2, 2024

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov-commenter commented Apr 2, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 77 lines in your changes are missing coverage. Please review.

Project coverage is 15.38%. Comparing base (38f0286) to head (a0423ac).
Report is 12 commits behind head on 4.19.

Files Patch % Lines
...atastore/driver/ScaleIOPrimaryDataStoreDriver.java 0.00% 48 Missing ⚠️
...stack/engine/orchestration/VolumeOrchestrator.java 0.00% 17 Missing ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java 0.00% 6 Missing ⚠️
...in/java/com/cloud/storage/ResizeVolumePayload.java 0.00% 4 Missing ⚠️
...rc/main/java/com/cloud/storage/VolumeDetailVO.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##               4.19    #8872       +/-   ##
=============================================
- Coverage     30.96%   15.38%   -15.58%     
+ Complexity    34330    13619    -20711     
=============================================
  Files          5355     4862      -493     
  Lines        376691   325959    -50732     
  Branches      54815    45824     -8991     
=============================================
- Hits         116626    50143    -66483     
- Misses       244692   268904    +24212     
+ Partials      15373     6912     -8461
Flag Coverage Δ
simulator-marvin-tests 15.38% <0.00%> (-9.41%) ⬇️
uitests ?
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan commented Apr 2, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9127

vishesh92 commented Apr 2, 2024

Copy link
Copy Markdown
Member Author

@blueorangutan test

blueorangutan commented Apr 2, 2024

Copy link
Copy Markdown

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Apr 3, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-9673)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48112 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8872-t9673-kvm-centos7.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_trigger_shutdown Failure 336.68 test_safe_shutdown.py

DaanHoogland commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan test alma9 kvm-alma9

blueorangutan commented Apr 4, 2024

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

blueorangutan commented Apr 4, 2024

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-9690)

vishesh92 commented Apr 4, 2024

Copy link
Copy Markdown
Member Author

@blueorangutan test alma9 kvm-alma9

blueorangutan commented Apr 4, 2024

Copy link
Copy Markdown

@vishesh92 a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

blueorangutan commented Apr 4, 2024

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-9695)

blueorangutan commented Apr 4, 2024

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-9696)

vishesh92 marked this pull request as draft April 4, 2024 11:54

vishesh92 commented Apr 4, 2024

Copy link
Copy Markdown
Member Author

@blueorangutan test alma9 kvm-alma9

blueorangutan commented Apr 4, 2024

Copy link
Copy Markdown

@vishesh92 a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

blueorangutan commented Apr 5, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-9711)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 47450 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8872-t9711-kvm-alma9.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

vishesh92 commented Apr 5, 2024

Copy link
Copy Markdown
Member Author

@blueorangutan package

blueorangutan commented Apr 5, 2024

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Apr 5, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9178

vishesh92 commented Apr 5, 2024

Copy link
Copy Markdown
Member Author

@blueorangutan test

blueorangutan commented Apr 5, 2024

Copy link
Copy Markdown

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Apr 6, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-9738)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47272 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8872-t9738-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

blueorangutan commented Apr 8, 2024

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Apr 8, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9190

sureshanaparti approved these changes Apr 8, 2024
View reviewed changes

sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

vishesh92 commented Apr 8, 2024

Copy link
Copy Markdown
Member Author

@blueorangutan test

blueorangutan commented Apr 8, 2024

Copy link
Copy Markdown

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Apr 9, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-9757)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50633 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8872-t9757-kvm-centos7.zip
Smoke tests completed. 124 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_list_system_vms_metrics_history Failure 0.21 test_metrics_api.py
test_list_vms_metrics_user Error 3643.43 test_metrics_api.py
test_create_pvlan_network Error 0.06 test_pvlan.py
test_04_deploy_vnf_appliance Error 102.49 test_vnf_templates.py
test_04_deploy_vnf_appliance Error 102.49 test_vnf_templates.py
test_05_delete_vnf_template Error 0.05 test_vnf_templates.py
ContextSuite context=TestVnfTemplates>:teardown Error 1.15 test_vnf_templates.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Error 337.39 test_vpc_redundant.py
test_02_redundant_VPC_default_routes Error 325.35 test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Error 252.03 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Error 172.80 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 267.11 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 267.12 test_vpc_redundant.py
test_01_VPC_nics_after_destroy Error 165.13 test_vpc_router_nics.py
test_02_VPC_default_routes Error 170.37 test_vpc_router_nics.py

borisstoyanov approved these changes Apr 10, 2024
View reviewed changes

borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, I'll run smoketests once more

borisstoyanov commented Apr 10, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented Apr 10, 2024

Copy link
Copy Markdown

@borisstoyanov a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Apr 10, 2024

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-9786)

yadvr modified the milestones: 4.20.0.0, 4.19.1.0 Apr 11, 2024

yadvr commented Apr 11, 2024

Copy link
Copy Markdown
Member

@blueorangutan test

yadvr marked this pull request as ready for review April 11, 2024 11:30
yadvr merged commit 730cc5d into apache:4.19 Apr 11, 2024

yadvr commented Apr 11, 2024

Copy link
Copy Markdown
Member

@blueorangutan test

blueorangutan commented Apr 11, 2024

Copy link
Copy Markdown

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Apr 11, 2024

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-9798)

weizhouapache mentioned this pull request Apr 12, 2024
Merged
13 tasks
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
Change iops on offering change (apache#8872)
b79263b 
* Change IOPS on disk offering change

* Remove iops & bandwidth limits before copying template

* minor refactor

* Handle diskOfferingDetails

* Fixup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sureshanaparti sureshanaparti approved these changes
borisstoyanov borisstoyanov approved these changes

Assignees

No one assigned

Labels

component:orchestration component:powerflex component:primary-storage component:storage

Projects

No open projects
Apache CloudStack 4.19.1
Status: No status

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL