FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Go back to previous timestamp on logging by JoaoJandre · Pull Request #8925 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Go back to previous timestamp on logging - #8925

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
scclouds:fix-logged-dates
Sep 5, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Go back to previous timestamp on logging#8925
DaanHoogland merged 1 commit into
apache:mainfrom
scclouds:fix-logged-dates

Conversation

JoaoJandre commented Apr 16, 2024

Copy link
Copy Markdown
Contributor

Description

Before #7131, the logs' timestamp was in the 2024-04-02 22:04:28,617, with the upgrade to log4j2, the logs' timestamp was changed to the 2024-04-02T21:55:12,724 format. This PR changes the timestamp back to the previous format.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

JoaoJandre added this to the 4.20.0.0 milestone Apr 16, 2024

JoaoJandre commented Apr 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The PR is ready for review, I just need to test it manually on all components, until then I'll keep it on draft.

DaanHoogland commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

Is this really needed @JoaoJandre ? seems to me this is a user choice and taking a standard as the default is not that bad a choice. (did you get complaints?)

JoaoJandre commented May 16, 2024

Copy link
Copy Markdown
Contributor Author

Is this really needed @JoaoJandre ? seems to me this is a user choice and taking a standard as the default is not that bad a choice. (did you get complaints?)

This will revert the default timestamp to what it used to be before the Log4j2 update, I mistakenly changed the default timestamp when upgrading the default log4j configurations on #7131. This PR will change the timestamp to the one that was being used before #7131.

The change on the timestamp pattern could break users' log parsers, that's why I created this PR. If they wish, they can change the value to ISO8601 or whatever they prefer.

JoaoJandre marked this pull request as ready for review May 16, 2024 17:19
FelipeM525 approved these changes Jul 18, 2024
View reviewed changes

FelipeM525 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

CLGTM!

DaanHoogland reopened this Jul 18, 2024

codecov Bot commented Jul 18, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.54%. Comparing base (a5508ac) to head (212337f).
Report is 1031 commits behind head on main.

Additional details and impacted files 
@@              Coverage Diff              @@
##               main    #8925       +/-   ##
=============================================
+ Coverage     13.17%   15.54%    +2.36%     
- Complexity     9214    11974     +2760     
=============================================
  Files          2725     5493     +2768     
  Lines        258235   481034   +222799     
  Branches      40249    58580    +18331     
=============================================
+ Hits          34013    74758    +40745     
- Misses       219913   398014   +178101     
- Partials       4309     8262     +3953
Flag Coverage Δ
uitests 4.17% <ø> (?)
unittests 16.30% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JoaoJandre commented Aug 6, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Aug 6, 2024

Copy link
Copy Markdown

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Aug 6, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10578

DaanHoogland commented Aug 12, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented Aug 12, 2024

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan commented Aug 12, 2024

Copy link
Copy Markdown

[SF] Trillian Build Failed (tid-11059)

DaanHoogland commented Aug 12, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Aug 12, 2024

Copy link
Copy Markdown

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Aug 12, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10619

DaanHoogland commented Aug 12, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan LLtest

blueorangutan commented Aug 12, 2024

Copy link
Copy Markdown

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr commented Sep 4, 2024

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented Sep 4, 2024

Copy link
Copy Markdown

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Sep 4, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10942

yadvr commented Sep 4, 2024

Copy link
Copy Markdown
Member

@blueorangutan test

blueorangutan commented Sep 4, 2024

Copy link
Copy Markdown

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sureshanaparti approved these changes Sep 4, 2024
View reviewed changes

sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

blueorangutan commented Sep 5, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-11337)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54157 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8925-t11337-kvm-ol8.zip
Smoke tests completed. 139 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

DaanHoogland merged commit 6a559f4 into apache:main Sep 5, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 6, 2024
Go back to default timestamp on logging (apache#8925)
04fe34a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland approved these changes
sureshanaparti sureshanaparti approved these changes
+1 more reviewer
FelipeM525 FelipeM525 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:agent component:hyperv component:LDAP component:logging component:usage-server

Projects

None yet

Milestone

4.20.0

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL