FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix comparison of Long objects to use primitives by JSpon · Pull Request #9079 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Fix comparison of Long objects to use primitives #9079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JSpon wants to merge 5 commits into from
Conversation 39 Commits 5 Checks 0 Files changed
Closed

Fix comparison of Long objects to use primitives #9079

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e41e1cb
Fix comparison of Long objects to use primitives
JSpon May 14, 2024
6da8548
Prevent NPE
JSpon Jun 10, 2024
1a2a39e
Update plugins/integrations/kubernetes-service/src/main/java/com/clou…
yadvr Sep 4, 2024
b854266
Update plugins/integrations/kubernetes-service/src/main/java/com/clou…
weizhouapache Sep 4, 2024
a61b2bd
Under certain circumstances, Long objects may differ even though they…
JSpon Jan 6, 2025
File filter

Filter by extension

Filter by extension .java  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion ...c/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterActionWorker.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ protected IpAddress getVpcTierKubernetesPublicIp(Network network) {
return null;
}
IpAddress address = ipAddressDao.findByUuid(detailsVO.getValue());
if (address == null || network.getVpcId() != address.getVpcId()) {
if (address == null || !address.getVpcId().equals(network.getVpcId()) {
Comment thread
weizhouapache marked this conversation as resolved.
Resolved
logger.warn(String.format("Public IP with ID: %s linked to the Kubernetes cluster: %s is not usable", detailsVO.getValue(), kubernetesCluster.getName()));
return null;
}
Expand Down
Back | FazBrowse Home | New Git URL