Repository navigation
CLOUDSTACK-8923: Do not send zoneId with createStorageNetworkIpRange command. - #911
Closed
borisroman wants to merge 2 commits into
Closed
borisroman wants to merge 2 commits into
borisroman wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
server/src/com/cloud/network/StorageNetworkManagerImpl.java
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
please don't comment out code, remove it
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
I know :) Still busy testing, please read the last comment of my PR message. I PR'd the first commit, then pushed the second one for testing.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Hi @borisroman any update on this? :-) |
Sorry, something went wrong.
yadvr
pushed a commit
that referenced
this pull request
Jan 20, 2021
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zoneId was send with the createStorageNetworkIpRange from the wizard. This isn't necessary. It will only remove the warning. It doesn't fix the transaction issue from CLOUDSTACK-8923 itself.