FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix bugs on last step on Wizard zone and Adv Search box by milamberspace · Pull Request #912 · apache/cloudstack · GitHub

Repository navigation

Fix bugs on last step on Wizard zone and Adv Search box - #912

Closed
milamberspace wants to merge 1 commit into
apache:masterfrom
milamberspace:BugZoneWizardAndAdvSearchPopup
Closed

milamberspace wants to merge 1 commit into
apache:masterfrom
milamberspace:BugZoneWizardAndAdvSearchPopup

Conversation

Copy link
Copy Markdown
Contributor

Javascript error: Uncaught ReferenceError: _ is not defined
Missing 'l' (to call the _l() function)

Bug introduce by me (#712)

For the zone wizard, the Next button isn't replace by Finish button and the steps don't display in the box.
For the Adv Search box, the label of search button is "submit" instead of "Search" (in en_US localization)

Javascript error: Uncaught ReferenceError: _ is not defined
=> Missing 'l' (to call the _l() function)

Bug introduce by me (apache#712)

For the zone wizard, the Next button isn't replace by Finish button and the steps don't display in the box.
For the Adv Search box, the label of search button is "submit" instead of "Search" (in en_US localization)
=

Copy link
Copy Markdown
Contributor Author

@remibergsma
Probably this is a 'minor' blocker bug for the 4.6 release.

Copy link
Copy Markdown
Contributor

@milamberspace Thanks, this we should include indeed. Will try to test in the coming days.

sebgoa commented Oct 5, 2015

Copy link
Copy Markdown
Member

@milamberspace @remibergsma there is a duplicate at #906

Copy link
Copy Markdown
Contributor Author

@Runseb Good catch!
Thanks @nitin-maharana to fix part of this bugs.
@remibergsma my PR add a bug on Adv search label.

Copy link
Copy Markdown
Contributor

I tried to run the wizard with this patch applied but the wizard doesn't show 'finished' nor does it finish after pressing 'next' for a final time. I shows a blank screen and then loops back to the beginning of the wizard.

Copy link
Copy Markdown
Contributor Author

@DaanHoogland you need to double-check that the old zoneWizard.js file is changed on you browser (clean cache) and on the tomcat installation (if not a new installation) in work/temp dir. I have a lot of problem to test that because even I clean my browser cache, the tomcat service continue to serve the old zoneWizard.js without the L in the _l() function. Finally I made a full clean installation of CS to validate my fixes.

Copy link
Copy Markdown
Contributor Author

Closed. New PR #915

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL