FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support migration of VM imported from a remote host by Pearl1594 · Pull Request #9259 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Support migration of VM imported from a remote host - #9259

Merged
vishesh92 merged 1 commit into
4.19from
8827-fix-migration-of-imported-vm-kvm
Jun 24, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Support migration of VM imported from a remote host#9259
vishesh92 merged 1 commit into
4.19from
8827-fix-migration-of-imported-vm-kvm

Conversation

Pearl1594 commented Jun 14, 2024

Copy link
Copy Markdown
Contributor

Description

This PR fixes: #8827
Importing a VM from a remote host uses a dummy VM template which is not present on the secondary store, leading to NPEs when migrating the VM. This PR enables migrating oly the volume (not the template)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Pearl1594 self-assigned this Jun 14, 2024
DaanHoogland changed the base branch from main to 4.19 June 14, 2024 13:03
DaanHoogland approved these changes Jun 14, 2024
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

CLGTM

DaanHoogland added this to the 4.19.1.0 milestone Jun 14, 2024

DaanHoogland commented Jun 14, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Jun 14, 2024

Copy link
Copy Markdown

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sureshanaparti commented Jun 14, 2024

Copy link
Copy Markdown
Contributor

@Pearl1594 Is this live migration of the volume, or offline?

Pearl1594 commented Jun 14, 2024

Copy link
Copy Markdown
Contributor Author

live migration @sureshanaparti

codecov Bot commented Jun 14, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 16.37%. Comparing base (0208e09) to head (2a96d9f).
Report is 167 commits behind head on 4.19.

Files Patch % Lines
...torage/motion/StorageSystemDataMotionStrategy.java 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##               4.19    #9259       +/-   ##
=============================================
- Coverage     30.91%   16.37%   -14.54%     
+ Complexity    34249    14581    -19668     
=============================================
  Files          5354     4857      -497     
  Lines        376094   325107    -50987     
  Branches      54696    45667     -9029     
=============================================
- Hits         116258    53244    -63014     
- Misses       244542   264286    +19744     
+ Partials      15294     7577     -7717
Flag Coverage Δ
simulator-marvin-tests 16.37% <0.00%> (-8.36%) ⬇️
uitests ?
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sureshanaparti approved these changes Jun 14, 2024
View reviewed changes

sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

blueorangutan commented Jun 14, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9960

vishesh92 commented Jun 20, 2024

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented Jun 20, 2024

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

apache deleted a comment from blueorangutan Jun 20, 2024

blueorangutan commented Jun 20, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10042

sureshanaparti commented Jun 20, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented Jun 20, 2024

Copy link
Copy Markdown

@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Jun 21, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-10540)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48752 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9259-t10540-kvm-centos7.zip
Smoke tests completed. 130 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_trigger_shutdown Failure 336.68 test_safe_shutdown.py

vishesh92 commented Jun 24, 2024

Copy link
Copy Markdown
Member

Tested the PR. Was able to reproduce the issue. Not able to reproduce it after this patch.

vishesh92 merged commit f792684 into 4.19 Jun 24, 2024
vishesh92 deleted the 8827-fix-migration-of-imported-vm-kvm branch June 24, 2024 07:16
sureshanaparti mentioned this pull request Jun 24, 2024
Closed
DaanHoogland mentioned this pull request Jul 1, 2024
Closed
2 of 11 tasks
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 2, 2024
Support migration of VM imported from a remote host (apache#9259)
81e614c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland approved these changes
sureshanaparti sureshanaparti approved these changes
shwstppr Awaiting requested review from shwstppr

Assignees

Pearl1594

Labels

component:migration component:storage

Projects

No open projects
Apache CloudStack 4.19.1
Status: Done

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

Unable to migrate instance that came from an external KVM host

5 participants

Back | FazBrowse Home | New Git URL