FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixed src datastore on copy check for PowerFlex/ScaleIO storage driver by sureshanaparti · Pull Request #9310 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Fixed src datastore on copy check for PowerFlex/ScaleIO storage driver - #9310

Merged
sureshanaparti merged 1 commit into
apache:4.18from
shapeblue:powerflex_scaleio_copy_check
Jun 28, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Fixed src datastore on copy check for PowerFlex/ScaleIO storage driver#9310
sureshanaparti merged 1 commit into
apache:4.18from
shapeblue:powerflex_scaleio_copy_check

Conversation

sureshanaparti commented Jun 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR fixes src datastore on copy check for PowerFlex/ScaleIO storage driver.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested volume migration from pool NFS -> PowerFlex and PowerFlex -> PowerFlex. NFS -> PowerFlex fails with not suitable error.

How did you try to break this feature and the system with this change?

sureshanaparti added this to the 4.19.1.0 milestone Jun 28, 2024

sureshanaparti commented Jun 28, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Jun 28, 2024

Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

slavkap approved these changes Jun 28, 2024
View reviewed changes

slavkap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

code LGTM

codecov Bot commented Jun 28, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 12.24%. Comparing base (6b25ed7) to head (36356cd).

Files Patch % Lines
...atastore/driver/ScaleIOPrimaryDataStoreDriver.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.18    #9310      +/-   ##
============================================
- Coverage     12.24%   12.24%   -0.01%     
+ Complexity     9296     9294       -2     
============================================
  Files          4699     4699              
  Lines        414339   414339              
  Branches      53023    53311     +288     
============================================
- Hits          50731    50727       -4     
- Misses       357303   357308       +5     
+ Partials       6305     6304       -1
Flag Coverage Δ
unittests 12.24% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan commented Jun 28, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10187

vishesh92 approved these changes Jun 28, 2024
View reviewed changes

vishesh92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

sureshanaparti merged commit 983f164 into apache:4.18 Jun 28, 2024
DaanHoogland deleted the powerflex_scaleio_copy_check branch July 1, 2024 06:51
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 2, 2024
Fixed src datastore on copy check for PowerFlex/ScaleIO storage driver (
82b8cf3 
apache#9310)
shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Sep 5, 2024
Back port fixes from upstream 4.19 (apache#466)
d1faa59 
* Fixed src datastore on copy check for PowerFlex/ScaleIO storage driver (apache#9310)

* Ignore non-managed pools for storage pool access preparation (apache#9376)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vishesh92 vishesh92 approved these changes
slavkap slavkap approved these changes
harikrishna-patnala Awaiting requested review from harikrishna-patnala

Assignees

No one assigned

Labels

component:powerflex component:primary-storage component:storage

Projects

No open projects
Apache CloudStack 4.19.1
Status: Done

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL