FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixup main build errors by vishesh92 · Pull Request #9330 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Fixup main build errors - #9330

Merged
sureshanaparti merged 3 commits into
apache:mainfrom
shapeblue:fixup-main-build
Jul 4, 2024
ConversationCommits (3)ChecksFiles changed
Merged

Fixup main build errors#9330
sureshanaparti merged 3 commits into
apache:mainfrom
shapeblue:fixup-main-build

Conversation

vishesh92 commented Jul 3, 2024

Copy link
Copy Markdown
Member

Description

This PR fixes build errors on main branch

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

vishesh92 requested a review from DaanHoogland July 3, 2024 09:19
sureshanaparti approved these changes Jul 3, 2024
View reviewed changes

sureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

sureshanaparti commented Jul 3, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Jul 3, 2024

Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

shwstppr approved these changes Jul 3, 2024
View reviewed changes

shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Can be merged once GH actions passes
Thanks @vishesh92

In general, we need to be more careful with forward-merging 4.19 into main as build is failing regularly lately

codecov Bot commented Jul 3, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 23.52941% with 26 lines in your changes missing coverage. Please review.

Project coverage is 15.51%. Comparing base (de683a5) to head (094107a).

Files Patch % Lines
...orage/datastore/manager/ScaleIOSDCManagerImpl.java 4.00% 24 Missing ⚠️
...e/lifecycle/BasePrimaryDataStoreLifeCycleImpl.java 80.00% 1 Missing ⚠️
...per/LibvirtCheckConvertInstanceCommandWrapper.java 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##              main    #9330       +/-   ##
============================================
+ Coverage     4.17%   15.51%   +11.34%     
- Complexity       0    11939    +11939     
============================================
  Files          371     5492     +5121     
  Lines        30407   480616   +450209     
  Branches      5384    61684    +56300     
============================================
+ Hits          1269    74575    +73306     
- Misses       28994   397788   +368794     
- Partials       144     8253     +8109
Flag Coverage Δ
uitests 4.17% <ø> (ø)
unittests 16.28% <23.52%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vishesh92 force-pushed the fixup-main-build branch 3 times, most recently from df1ee81 to aef5a9c Compare July 3, 2024 10:09
DaanHoogland approved these changes Jul 3, 2024
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

blueorangutan commented Jul 3, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10239

yadvr added this to the 4.20.0.0 milestone Jul 3, 2024

sureshanaparti commented Jul 4, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Jul 4, 2024

Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Jul 4, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10246

sureshanaparti merged commit 7c32bd2 into apache:main Jul 4, 2024
vishesh92 deleted the fixup-main-build branch July 4, 2024 07:31
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 15, 2024
Fixup main build errors (apache#9330)
d6d24cf 
* Fixup main build errors

* Fixup flaky test

* Address comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JoaoJandre JoaoJandre left review comments
weizhouapache weizhouapache left review comments
yadvr yadvr approved these changes
shwstppr shwstppr approved these changes
DaanHoogland DaanHoogland approved these changes
sureshanaparti sureshanaparti approved these changes

Assignees

No one assigned

Labels

component:kvm component:primary-storage component:quota component:solidfire component:storage

Projects

None yet

Milestone

4.20.0

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL