FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix component tests test_acl_isolatednetwork and test_acl_isolatednetwork_delete by weizhouapache · Pull Request #9571 · apache/cloudstack · GitHub

/ cloudstack Public

test: fix component tests test_acl_isolatednetwork and test_acl_isolatednetwork_delete - #9571

Merged
weizhouapache merged 2 commits into
apache:4.19from
weizhouapache:4.19-fix-component-test_acl_isolatednetwork
Aug 23, 2024
ConversationCommits (2)ChecksFiles changed
Merged

test: fix component tests test_acl_isolatednetwork and test_acl_isolatednetwork_delete#9571
weizhouapache merged 2 commits into
apache:4.19from
weizhouapache:4.19-fix-component-test_acl_isolatednetwork

Conversation

weizhouapache commented Aug 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR fixes the component test failures

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

boring-cyborg Bot added component:integration-test Python Warning... Python code Ahead! labels Aug 22, 2024
weizhouapache changed the title test: fix component tests test_acl_isolatednetwork and test_acl_isola… test: fix component tests test_acl_isolatednetwork and test_acl_isolatednetwork_delete Aug 22, 2024

codecov Bot commented Aug 22, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.08%. Comparing base (1a403f1) to head (35ae107).
Report is 1 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff             @@
##               4.19    #9571     +/-   ##
===========================================
  Coverage     15.08%   15.08%             
- Complexity    11181    11184      +3     
===========================================
  Files          5406     5406             
  Lines        472915   472915             
  Branches      58400    60886   +2486     
===========================================
+ Hits          71336    71345      +9     
+ Misses       393637   393624     -13     
- Partials       7942     7946      +4
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

apache deleted a comment from blueorangutan Aug 22, 2024

DaanHoogland commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Aug 22, 2024

Copy link
Copy Markdown

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Aug 22, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10759

vishesh92 approved these changes Aug 23, 2024
View reviewed changes

vishesh92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

weizhouapache marked this pull request as ready for review August 23, 2024 17:26

weizhouapache commented Aug 23, 2024

Copy link
Copy Markdown
Member Author

All simulator CI tests passed
merging

weizhouapache merged commit 0597def into apache:4.19 Aug 23, 2024
DaanHoogland deleted the 4.19-fix-component-test_acl_isolatednetwork branch August 25, 2024 19:20
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 30, 2024
test: fix component tests test_acl_isolatednetwork and test_acl_isola…
4d477e2 
…tednetwork_delete (apache#9571)

* test: fix component tests test_acl_isolatednetwork and test_acl_isolatednetwork_delete

* Update test/integration/component/test_acl_isolatednetwork.py
DaanHoogland added this to the 4.19.2.0 milestone Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vishesh92 vishesh92 approved these changes

Assignees

No one assigned

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL