FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[PowerFlex] Add & Remove PowerFlex/ScaleIO MDMs for the storage SDC connections by sureshanaparti · Pull Request #9903 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

[PowerFlex] Add & Remove PowerFlex/ScaleIO MDMs for the storage SDC connections - #9903

Merged
sureshanaparti merged 8 commits into
apache:mainfrom
shapeblue:powerflex_scaleio-connection-with-mdms
May 15, 2025
ConversationCommits (8)ChecksFiles changed
Merged

[PowerFlex] Add & Remove PowerFlex/ScaleIO MDMs for the storage SDC connections#9903
sureshanaparti merged 8 commits into
apache:mainfrom
shapeblue:powerflex_scaleio-connection-with-mdms

Conversation

sureshanaparti commented Nov 7, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds & removes PowerFlex/ScaleIO MDM IP addressess while preparing & unpreparing the storage SDC connections (instead of start & stop scini), when powerflex.connect.on.demand is true. And adds & removes MDM IP addresses during Host connection/disconnection to/from storage pool, when powerflex.connect.on.demand is false.

MDMs details persisted using powerflex.storagepool.mdms detail, in storage_pool_details table:

mysql> SELECT * FROM cloud.storage_pool_details WHERE pool_id = 3 AND name = 'powerflex.storagepool.mdms';
+----+---------+---------------------------------+------------------------------------------------------+---------+
| id | pool_id | name                            | value                                                | display |
+----+---------+---------------------------------+------------------------------------------------------+---------+
|  2 |       3 | powerflex.storagepool.mdms      | 10.0.33.178,10.0.33.87                               |       1 |
+----+---------+---------------------------------+------------------------------------------------------+---------+

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested VM start/stop operations, noticed MDMs added/removed in hosts.

sureshanaparti added this to the 4.21.0.0 milestone Nov 7, 2024

sureshanaparti commented Nov 7, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Nov 7, 2024

Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov Bot commented Nov 7, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 9.29095% with 371 lines in your changes missing coverage. Please review.

Project coverage is 16.41%. Comparing base (2df1ac5) to head (538d0f1).
Report is 101 commits behind head on main.

Files with missing lines Patch % Lines
...orage/datastore/manager/ScaleIOSDCManagerImpl.java 0.00% 74 Missing ⚠️
...torage/datastore/provider/ScaleIOHostListener.java 0.00% 68 Missing ⚠️
.../hypervisor/kvm/storage/ScaleIOStorageAdaptor.java 21.62% 25 Missing and 4 partials ⚠️
...atastore/driver/ScaleIOPrimaryDataStoreDriver.java 10.34% 25 Missing and 1 partial ⚠️
...re/lifecycle/ScaleIOPrimaryDataStoreLifeCycle.java 33.33% 17 Missing and 3 partials ⚠️
...ck/storage/datastore/api/StorageConfiguration.java 0.00% 19 Missing ⚠️
.../hypervisor/kvm/storage/KVMStoragePoolManager.java 0.00% 17 Missing ⚠️
...cloudstack/storage/datastore/util/ScaleIOUtil.java 50.00% 14 Missing and 2 partials ⚠️
...ore/client/ScaleIOGatewayClientConnectionPool.java 0.00% 14 Missing ⚠️
...a/com/cloud/storage/StoragePoolAutomationImpl.java 0.00% 11 Missing ⚠️
... and 14 more
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #9903      +/-   ##
============================================
- Coverage     16.42%   16.41%   -0.01%     
+ Complexity    13549    13547       -2     
============================================
  Files          5673     5676       +3     
  Lines        500080   500420     +340     
  Branches      60506    60575      +69     
============================================
+ Hits          82153    82168      +15     
- Misses       408794   409103     +309     
- Partials       9133     9149      +16
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.28% <9.29%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan commented Nov 7, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11524

sureshanaparti commented Nov 11, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

blueorangutan commented Nov 11, 2024

Copy link
Copy Markdown

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan commented Nov 12, 2024

Copy link
Copy Markdown

[SF] Trillian test result (tid-11772)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58105 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9903-t11772-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_unsecure_vm_migration Error 503.38 test_vm_life_cycle.py

sureshanaparti commented Dec 24, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Dec 24, 2024

Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sureshanaparti changed the title [PowerFlex] Add & Remove PowerFlex/ScaleIO MDMs while preparing & unpreparing the storage SDC connections [PowerFlex] Add & Remove PowerFlex/ScaleIO MDMs for the storage SDC connections Dec 24, 2024

blueorangutan commented Dec 24, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11894

sureshanaparti force-pushed the powerflex_scaleio-connection-with-mdms branch from c8603d2 to 86f5f0c Compare December 26, 2024 06:10

sureshanaparti commented Dec 26, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Dec 26, 2024

Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Dec 26, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11910

apache deleted a comment from blueorangutan Dec 27, 2024
apache deleted a comment from blueorangutan Dec 27, 2024

sureshanaparti commented Dec 27, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

blueorangutan commented Dec 27, 2024

Copy link
Copy Markdown

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sureshanaparti force-pushed the powerflex_scaleio-connection-with-mdms branch from e7b0700 to b065389 Compare December 27, 2024 14:01
apache deleted a comment from blueorangutan Dec 27, 2024

sureshanaparti commented Dec 27, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Dec 27, 2024

Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

apache deleted a comment from blueorangutan Dec 27, 2024

blueorangutan commented Dec 27, 2024

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11925

sureshanaparti force-pushed the powerflex_scaleio-connection-with-mdms branch from 8d20c7f to 538d0f1 Compare April 30, 2025 10:35

sureshanaparti commented Apr 30, 2025

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Apr 30, 2025

Copy link
Copy Markdown

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented Apr 30, 2025

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13227

sureshanaparti commented May 5, 2025

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

blueorangutan commented May 5, 2025

Copy link
Copy Markdown

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan commented May 5, 2025

Copy link
Copy Markdown

[SF] Trillian test result (tid-13202)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52889 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9903-t13202-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_restore_vm_strict_tags_failure Failure 53.35 test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure Failure 56.73 test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure Failure 3.66 test_vm_strict_host_tags.py

harikrishna-patnala approved these changes May 6, 2025
View reviewed changes

harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

code LGTM

kiranchavala approved these changes May 14, 2025
View reviewed changes

kiranchavala left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Steps to validata

  1. Add a powerflex storage to the cloudstack setup

  2. Make sure the global setting "powerflex.connect.on.demand " is set to false

  3. Login to the kvm host make sure the scini service is running

yum install EMC-ScaleIO-sdc-3.6-400.107.el8.x86_64.rpm -y
systemctl status scini.service
  1. Stop the service

systemctl status scini.service

  1. Deploy the vm

The vm deployment will fail

  1. Enable the global setting "powerflex.connect.on.demand" to true

  2. Deploy a vm

The vm deployment will succed

  1. Check the scini service

systemctl status scini.service

It should be in active state and started by Cloudstack

sureshanaparti commented May 15, 2025

Copy link
Copy Markdown
Contributor Author

Merging this, based on the reviews and tests.

sureshanaparti merged commit 572fc11 into apache:main May 15, 2025
DaanHoogland deleted the powerflex_scaleio-connection-with-mdms branch May 15, 2025 07:31
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
[PowerFlex] Add & Remove PowerFlex/ScaleIO MDMs for the storage SDC c…
5163488 
…onnections (apache#9903)

* Add & Remove PowerFlex/ScaleIO MDMs while preparing & unpreparing the storage SDC connections (instead of start & stop scini)

* Add/Remove MDM IP addresses during Host connection/disconnection to/from storage pool when powerflex.connect.on.demand is false

* unit test fixes

* Don't remove MDM IPs from SDC when any volumes mapped to SDC

* Don't remove MDM IPs when other pools of same ScaleIO/PowerFlex cluster are connected

* rebase fixes

* update changes, to not remove/disconnect MDMs on maintenance

* import fixes after rebase
sureshanaparti mentioned this pull request Jun 27, 2025
Merged
2 of 14 tasks
sureshanaparti mentioned this pull request Aug 15, 2025
Merged
2 of 14 tasks
weizhouapache mentioned this pull request Oct 1, 2025
Closed
sureshanaparti mentioned this pull request Oct 29, 2025
Merged
2 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kiranchavala kiranchavala approved these changes
harikrishna-patnala harikrishna-patnala approved these changes

Assignees

kiranchavala

Labels

component:api component:kvm component:primary-storage component:storage type:improvement

Projects

No open projects
Apache CloudStack 4.21.0
Status: Done

Milestone

4.21.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL