FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Configure Root disk size via Service Offering by GabrielBrascher · Pull Request #162 · apache/cloudstack-documentation · GitHub

  1. apache
  2. cloudstack-documentation

Repository navigation

Configure Root disk size via Service Offering - #162

Merged
DaanHoogland merged 4 commits into
apache:masterfrom
GabrielBrascher:resize-root-serviceoffering
Dec 11, 2020
ConversationCommits (4)ChecksFiles changed
Merged

Configure Root disk size via Service Offering#162
DaanHoogland merged 4 commits into
apache:masterfrom
GabrielBrascher:resize-root-serviceoffering

Conversation

GabrielBrascher commented Oct 9, 2020

Copy link
Copy Markdown
Member

This documentation is based on PR apache/cloudstack#4341: Allow to configure root disk size via Service Offering (diskoffering of type Service).

GabrielBrascher force-pushed the resize-root-serviceoffering branch 4 times, most recently from 99953db to a1b1741 Compare October 9, 2020 19:48
Configure Root disk size via Service Offering
5638e3f 
Based on PR at apache/cloudstack repository:
 - #4341: Allow to configure root disk size via Service Offering (diskoffering of type Service).
GabrielBrascher force-pushed the resize-root-serviceoffering branch from a1b1741 to 5638e3f Compare October 9, 2020 19:49
GabrielBrascher marked this pull request as ready for review October 9, 2020 19:50

GabrielBrascher commented Oct 9, 2020

Copy link
Copy Markdown
Member Author

requesting docbuild

ACSGitBot commented Oct 9, 2020

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

ACSGitBot commented Oct 9, 2020

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr162

Build Log Output:

No log errors found to report.

GabrielBrascher commented Oct 12, 2020

Copy link
Copy Markdown
Member Author

requesting docbuild

ACSGitBot commented Oct 12, 2020

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

ACSGitBot commented Oct 12, 2020

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr162

Build Log Output:

No log errors found to report.

GabrielBrascher self-assigned this Oct 12, 2020
DaanHoogland reviewed Oct 13, 2020
View reviewed changes
Comment thread source/adminguide/storage.rst
+---+----------------------------+---------------------------+-------------------------------+
| 4 | 10GB | 5GB | NO |
+---+----------------------------+---------------------------+-------------------------------+
| 5 | Any | 0GB | YES |

DaanHoogland Oct 13, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

as you state below that shrinking is not supported, I think an extra remark on this line is in order. It certainly implies that shrinking is allowed.

yadvr added this to the 4.15 milestone Nov 11, 2020

GabrielBrascher commented Nov 12, 2020

Copy link
Copy Markdown
Member Author

requesting docbuild

ACSGitBot commented Nov 12, 2020

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

ACSGitBot commented Nov 12, 2020

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr162//

Build Log Output:

No log errors found to report.//

GabrielBrascher commented Nov 12, 2020

Copy link
Copy Markdown
Member Author

requesting docbuild

ACSGitBot commented Nov 12, 2020

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

GabrielBrascher commented Nov 12, 2020
View reviewed changes
Comment thread source/adminguide/storage.rst
+---+----------------------------+---------------------------+-------------------------------+

.. note::
Shrinking the Root disk is not supported via the service offering resizing workflow. All the combinations above assume a transition to Root disks with size equals or bigger than the original.

GabrielBrascher Nov 12, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@DaanHoogland does this disclaimer suffice your concerns?

ACSGitBot commented Nov 12, 2020

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr162//

Build Log Output:

No log errors found to report.//

GabrielBrascher commented Nov 12, 2020

Copy link
Copy Markdown
Member Author

requesting docbuild

ACSGitBot commented Nov 12, 2020

Copy link
Copy Markdown

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

ACSGitBot commented Nov 12, 2020

Copy link
Copy Markdown

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr162//

Build Log Output:

No log errors found to report.//

DaanHoogland commented Dec 11, 2020

Copy link
Copy Markdown
Contributor

@GabrielBrascher is this good to go (That extra not should do for now)?

GabrielBrascher commented Dec 11, 2020

Copy link
Copy Markdown
Member Author

@DaanHoogland I think it is good to go. Please let me know if there is anything still missing or if the text is not clear about the disk offering root disk size.

Thanks for the review!

DaanHoogland merged commit 5d6ef85 into apache:master Dec 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland left review comments

Assignees

GabrielBrascher

Labels

None yet

Projects

None yet

Milestone

4.15

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL