FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feature: webhooks by shwstppr · Pull Request #385 · apache/cloudstack-documentation · GitHub

  1. apache
  2. cloudstack-documentation

Repository navigation

feature: webhooks - #385

Merged
yadvr merged 7 commits into
apache:mainfrom
shapeblue:feature-webhooks
Jun 10, 2024
ConversationCommits (7)ChecksFiles changed
Merged

feature: webhooks#385
yadvr merged 7 commits into
apache:mainfrom
shapeblue:feature-webhooks

Conversation

shwstppr commented Feb 29, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

feature: webhooks
742f548 
Documentation for apache/cloudstack#8674
changes
7fac505 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
changes
e9745f3 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
shwstppr changed the title Feature webhooks feature: webhooks Feb 29, 2024
apache deleted a comment from blueorangutan Feb 29, 2024
apache deleted a comment from blueorangutan Feb 29, 2024
changes
9e19afe 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
apache deleted a comment from blueorangutan Feb 29, 2024
apache deleted a comment from blueorangutan Feb 29, 2024

shwstppr commented Feb 29, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan docbuild

blueorangutan commented Feb 29, 2024

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

blueorangutan commented Feb 29, 2024

Copy link
Copy Markdown

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/385. (QA-JID 218)

shwstppr mentioned this pull request Feb 29, 2024
Merged
1 of 13 tasks

DaanHoogland commented Apr 8, 2024

Copy link
Copy Markdown
Contributor

@shwstppr , if I search for webhooks I get both a hit on the events page and a separate page. Is that on purpose? These seem to contain the same text.

also:

I think the text "|create-webhooks.png|"/link should not be there, but the picture should be embedded.

shwstppr commented Apr 8, 2024
View reviewed changes
Comment thread source/adminguide/events/webhooks.rst Resolved

shwstppr commented Apr 8, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan docbuild

@DaanHoogland I'm not sure about the way search works on the documentation website but since webhooks-related notes are in a separate .rst file, it could be the reason two search entries are showing.
I've added a fix for image not showing

blueorangutan commented Apr 8, 2024

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

blueorangutan commented Apr 8, 2024

Copy link
Copy Markdown

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/385. (QA-JID 221)

note regarding duplicate event deliveries
c3eda7b 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr commented Apr 8, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan docbuild

blueorangutan commented Apr 8, 2024

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

blueorangutan commented Apr 8, 2024

Copy link
Copy Markdown

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/385. (QA-JID 223)

note on self-signed https payload url
873a1c3 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr commented May 1, 2024

Copy link
Copy Markdown
Contributor Author

@blueorangutan docbuild

blueorangutan commented May 1, 2024

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

blueorangutan commented May 1, 2024

Copy link
Copy Markdown

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/385. (QA-JID 230)

kiranchavala approved these changes May 23, 2024
View reviewed changes

kiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM , the documentation looks good

shwstppr marked this pull request as ready for review June 5, 2024 11:09
shwstppr marked this pull request as draft June 5, 2024 11:14
yadvr marked this pull request as ready for review June 7, 2024 09:43
yadvr approved these changes Jun 7, 2024
View reviewed changes

yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, let's merge this when the linked PR is merged.

yadvr added this to the 4.20 milestone Jun 7, 2024
yadvr merged commit e5bc36d into apache:main Jun 10, 2024
yadvr deleted the feature-webhooks branch June 10, 2024 05:10
GaOrtiga pushed a commit to GaOrtiga/cloudstack-documentation that referenced this pull request Jun 28, 2024
feature: webhooks (apache#385)
1ba3689 
* feature: webhooks

Documentation for apache/cloudstack#8674

* changes

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* changes

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* changes

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* Update source/adminguide/events/webhooks.rst

* note regarding duplicate event deliveries

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* note on self-signed https payload url

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

---------

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
kiranchavala kiranchavala approved these changes
DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.20.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL