FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add rootdisk size on compute offering by GabrielBrascher · Pull Request #770 · apache/cloudstack-primate · GitHub

This repository was archived by the owner on Jan 20, 2021. It is now read-only.
  1. apache
  2. cloudstack-primate

Repository navigation

Add rootdisk size on compute offering - #770

Merged
yadvr merged 2 commits into
apache:masterfrom
PCextreme:root-size-service-offering
Oct 1, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Add rootdisk size on compute offering#770
yadvr merged 2 commits into
apache:masterfrom
PCextreme:root-size-service-offering

Conversation

GabrielBrascher commented Sep 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR allows configuring a Service Offering with root disk size.
PR Allow to configure root disk size via Service Offering (disk offering of type Service). #4341 allows enforcing VM Root disk size accordingly to its Service Offering.

NOTE: Once PR apache/cloudstack#4341 gets merged, the code of this PR will "work" with the new parameter at the API

How Has This Been Tested?

Screenshots:

  1. Empty:

  2. Value not supported:

  3. Value for Root disk size supported:

GabrielBrascher added the enhancement New feature or request label Sep 29, 2020
GabrielBrascher self-assigned this Sep 29, 2020
GabrielBrascher force-pushed the root-size-service-offering branch from 9750d6b to c420fd9 Compare September 29, 2020 21:36
GabrielBrascher force-pushed the root-size-service-offering branch from c420fd9 to 856adc4 Compare September 29, 2020 21:56

GabrielBrascher commented Sep 29, 2020

Copy link
Copy Markdown
Member Author

@blueorangutan package

blueorangutan commented Sep 29, 2020

Copy link
Copy Markdown

@GabrielBrascher a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

GabrielBrascher changed the title Add rootdisk size oncompute offering Add rootdisk size on compute offering Sep 29, 2020

blueorangutan commented Sep 29, 2020

Copy link
Copy Markdown

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/770 (JID-3542)

davidjumani reviewed Sep 30, 2020
View reviewed changes
Comment thread src/views/offering/AddComputeOffering.vue Resolved
davidjumani reviewed Sep 30, 2020
View reviewed changes
Comment thread src/views/offering/AddComputeOffering.vue Resolved

davidjumani commented Sep 30, 2020

Copy link
Copy Markdown
Contributor

@blueorangutan package

yadvr added this to the 1.0-GA milestone Sep 30, 2020

yadvr commented Sep 30, 2020

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented Sep 30, 2020

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan commented Sep 30, 2020

Copy link
Copy Markdown

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/770 (JID-3547)

davidjumani approved these changes Sep 30, 2020
View reviewed changes

davidjumani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code LGTM. Need to test once the ACS PR has been merged

yadvr merged commit 0ef66c6 into apache:master Oct 1, 2020
weizhouapache pushed a commit that referenced this pull request Jan 19, 2021
Add rootdisk size on compute offering (#770)
0642c3a 
* Add rootdisk size oncompute offering

* Change "leftover" apiParams.provisioningtype to apiParams.rootdisk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
davidjumani davidjumani approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

GabrielBrascher

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.0-GA

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL