FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

vm: backend migration changes support by shwstppr · Pull Request #789 · apache/cloudstack-primate · GitHub

This repository was archived by the owner on Jan 20, 2021. It is now read-only.
  1. apache
  2. cloudstack-primate

Repository navigation

vm: backend migration changes support - #789

Open
shwstppr wants to merge 12 commits into
apache:masterfrom
shapeblue:vm-migrate-backend-improvements
ConversationCommits (12)ChecksFiles changed
Open

vm: backend migration changes support#789
shwstppr wants to merge 12 commits into
apache:masterfrom
shapeblue:vm-migrate-backend-improvements

Conversation

shwstppr commented Oct 6, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Backend changes at apache/cloudstack#4385

Use migrateVirtualMachineWithVolume for stopped VM migration to a different storage pool
VR and system VM migration between cluster changes

Screenshots:

vm: backend migration changes support
506bcf6 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

blueorangutan commented Oct 6, 2020

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

add missing file
5910756 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
yadvr added this to the 1.1 milestone Oct 6, 2020

borisstoyanov commented Nov 3, 2020

Copy link
Copy Markdown

@blueorangutan package

blueorangutan commented Nov 3, 2020

Copy link
Copy Markdown

@borisstoyanov a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan commented Nov 3, 2020

Copy link
Copy Markdown

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/789 (JID-3641)

show storage migration required
92dd3c7 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
show cluster, pod name
48e02d9 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
yadvr approved these changes Nov 10, 2020
View reviewed changes

yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, needs manual testing against backend PR

fix vm storage migration
53603ac 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
fix
a4b457f 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
wip changes
9ae20c5 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
fix
a9099bc 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Merge branch 'master' into vm-migrate-backend-improvements
186d36b 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This was referenced Nov 20, 2020
Merged
Merged

shwstppr commented Nov 20, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Nov 20, 2020

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

shwstppr requested a review from yadvr November 20, 2020 11:45

blueorangutan commented Nov 20, 2020

Copy link
Copy Markdown

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/789 (JID-3682)

shwstppr commented Dec 10, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Dec 10, 2020

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan commented Dec 10, 2020

Copy link
Copy Markdown

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/789 (JID-3731)

shwstppr mentioned this pull request Dec 29, 2020
Closed
shwstppr marked this pull request as ready for review January 18, 2021 07:36

shwstppr commented Jan 18, 2021

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Jan 18, 2021

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan commented Jan 18, 2021

Copy link
Copy Markdown

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/789 (JID-3814)

yadvr commented Jan 18, 2021

Copy link
Copy Markdown
Member

@shwstppr can you add the link to the backend PR on PR description

shwstppr commented Jan 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@rhtyd it was there in the end. Moved it to top

sureshanaparti reviewed Jan 19, 2021
View reviewed changes
Comment thread src/locales/en.json Outdated
"label.storage.tags": "Storage Tags",
"label.storage.traffic": "Storage Traffic",
"label.storageid": "Primary Storage",
"label.storagemigrationrequired": "Storage Migration Required",

sureshanaparti Jan 19, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"label.storage.migration.required" key might look better

shwstppr Jan 19, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@sureshanaparti done

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

davidjumani Awaiting requested review from davidjumani
yadvr Awaiting requested review from yadvr
1 more reviewer
sureshanaparti sureshanaparti left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL