FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use scaleVirtualMachine API instead of changeServiceForVirtualMachine by Pearl1594 · Pull Request #818 · apache/cloudstack-primate · GitHub

This repository was archived by the owner on Jan 20, 2021. It is now read-only.
  1. apache
  2. cloudstack-primate

Repository navigation

Use scaleVirtualMachine API instead of changeServiceForVirtualMachine - #818

Merged
yadvr merged 1 commit into
apache:masterfrom
shapeblue:fix_scale_vm
Oct 30, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Use scaleVirtualMachine API instead of changeServiceForVirtualMachine#818
yadvr merged 1 commit into
apache:masterfrom
shapeblue:fix_scale_vm

Conversation

Pearl1594 commented Oct 23, 2020

Copy link
Copy Markdown
Contributor

Align with Legacy UI and call scaleVirtualMachine API when attempting scaling

Pearl1594 commented Oct 23, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Oct 23, 2020

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan commented Oct 23, 2020

Copy link
Copy Markdown

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/818 (JID-3613)

yadvr requested review from davidjumani and shwstppr October 23, 2020 11:46
yadvr added this to the 1.0-GA milestone Oct 23, 2020

GabrielBrascher commented Oct 27, 2020

Copy link
Copy Markdown
Member

For reference, here follows some CloudStack issues raised due to changeServiceForVIrtualMachine API command problems:

davidjumani commented Oct 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks @GabrielBrascher There were a few other reasons we went with changeServiceForVirtualMachine when the VM is stopped which I can't recall atm

yadvr commented Oct 28, 2020

Copy link
Copy Markdown
Member

@davidjumani @Pearl1594 @shwstppr can you share reasons for the change - thanks. I see legacy UI uses the scale API, is that it?

shwstppr approved these changes Oct 28, 2020
View reviewed changes

shwstppr left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Consistent with legacy UI. As per apache/cloudstack#4125 changeServiceForVirtualMachine seems to be having issues and scaleVirtualMachine handles both running and stopped VMs.
@davidjumani if there is any corner case failing we can handle in backend

Pearl1594 commented Oct 28, 2020

Copy link
Copy Markdown
Contributor Author

@rhtyd

  1. changeServiceForVirtualMachine isn't used by the legacy UI either when we attempt scaling
  2. scaleVirtualMachine does what changeServiceForVirtualMachine does - i.e., updates the service offering, and in addition to that, it also performs volume resizing.

GabrielBrascher approved these changes Oct 29, 2020
View reviewed changes

GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code LGTM.

CloudStack UI currently also does not use the changeServiceForVIrtualMachine. Additionally, there are a couple of open issues regarding changeServiceForVIrtualMachine API command problems:

yadvr merged commit 77a59f6 into apache:master Oct 30, 2020
Pearl1594 mentioned this pull request Oct 30, 2020
Merged
2 of 5 tasks
Pearl1594 added a commit to shapeblue/cloudstack-primate that referenced this pull request Nov 11, 2020
Use scaleVirtualMachine API instead of changeServiceForVirtualMachine (…
eb423ab 
…apache#818)

Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
GabrielBrascher mentioned this pull request Nov 18, 2020
Closed
weizhouapache pushed a commit that referenced this pull request Jan 19, 2021
Use scaleVirtualMachine API instead of changeServiceForVirtualMachine (…
fb4290f 
…#818)

Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

davidjumani Awaiting requested review from davidjumani
2 more reviewers
shwstppr shwstppr approved these changes
GabrielBrascher GabrielBrascher approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0-GA

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL