feat!: remove default build dir overrides - #1310
Merged
erisu merged 1 commit intoMay 28, 2023
Merged
erisu merged 1 commit into
erisu merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #1310 +/- ##
=======================================
Coverage 78.48% 78.49%
=======================================
Files 15 15
Lines 1780 1790 +10
=======================================
+ Hits 1397 1405 +8
- Misses 383 385 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sorry, something went wrong.
3 tasks done
dpogue
force-pushed
the
dir-settings
branch
2 times, most recently
from
7e70eea to
0da4b51
Compare
April 16, 2023 07:02
Once upon a time, Xcode's default directory values had issues when there were spaces in project names, so we override the CONFIGURATION_BUILD_DIR and SHARED_PRECOMPS_DIR variables with our own paths. However, this can interfere with Cocoapods, and Xcode should be able to handle things sensibly nowadays. Unfortunately, that results in our build artifacts living somewhere in a randomly-named Xcode DerivedData directory, and then we can't do things like run the app in a simulator or on a device because we don't know the path to it. Setting SYMROOT allows us to control the output directory of the built products, with the caveat that Xcode always creates a subdirectory named with the current configuration. So instead of `build/emulator`, we'll have `build/Debug-iphonesimulator` and instead of `build/device`, we'll have `build/Release-iphoneos`. Hypothetically this is better because now we are sure that debug and release files never get mixed up in the same output directory. The downside is that this is a breaking change because it alters the path for the output .ipa files. Closes apache#617. Closes apache#659. Closes apache#671. Co-Authored-By: Susan Tan <onceuponatimeforever@gmail.com>
erisu
approved these changes
Apr 16, 2023
erisu
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Code Changes LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Specifying CONFIGURATION_BUILD_DIR can cause issues with Cocoapods.
Closes #617
Closes #659
Closes #671
Description
Once upon a time, Xcode's default directory values had issues when there were spaces in project names, so we override the CONFIGURATION_BUILD_DIR and SHARED_PRECOMPS_DIR variables with our own paths.
However, this can interfere with Cocoapods, and Xcode should be able to handle things sensibly nowadays.
Unfortunately, that results in our build artifacts living somewhere in a randomly-named Xcode DerivedData directory, and then we can't do things like run the app in a simulator or on a device because we don't know the path to it. 🤦🏼♂️
Setting SYMROOT allows us to control the output directory of the built products, with the caveat that Xcode always creates a subdirectory named with the current configuration.
So instead of build/emulator, we'll have build/Debug-iphonesimulator and instead of build/device, we'll have build/Release-iphoneos.
Hypothetically this is better because now we are sure that debug and release files never get mixed up in the same output directory.
The downside is that this is a breaking change because it alters the path for the output .ipa files.
Testing
Checklist