changesreader /added fields & body support - #266
Open
hexnickk wants to merge 2 commits into
Open
hexnickk wants to merge 2 commits into
hexnickk wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
glynnbird
requested changes
Aug 25, 2021
Comment thread
lib/nano.d.ts
| body?: object; | ||
| /** a MangoSelector defining the slice of the changes feed to return */ | ||
| selector?: MangoSelector; | ||
| /** a MangoSelector defining changes feed fields to return */ |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
A small error: this isn't a MangoSelector, it's an array. :)
Sorry, something went wrong.
Comment thread
lib/changesreader.js
| if (self.selector) { | ||
| req.body.selector = self.selector | ||
| } | ||
| if (self.fields) { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I don't see anything in the CouchDB docs saying that a fields array can be supplied. Am I missing something?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR is addressing issue #263
In simple words, it is adding support for fields and body params for changesreader.
Testing recommendations
You can run this code against any running CouchDB database e.g. https://registry.npmjs.org/
db.changesReader .start({ fields }) .on('changes', console.log);GitHub issue number
#263
Checklist