Enable more clippy lints - #24566
Open
emilk wants to merge 10 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
emilk
marked this pull request as ready for review
August 21, 2026 17:41
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 84.83146% with 81 lines in your changes missing coverage. Please review. @@ Coverage Diff @@
## main #24566 +/- ##
========================================
Coverage 81.48% 81.48%
========================================
Files 1122 1122
Lines 404248 404381 +133
Branches 404248 404381 +133
========================================
+ Hits 329390 329511 +121
- Misses 55547 55558 +11
- Partials 19311 19312 +1 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Remove a dead `let _expected = …` binding left over from a removed assertion. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Compare the file extension with `Path::extension()` instead of
`str::ends_with(".csv")`.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
All five hits are FFI local-bypass tests that downcast a trait object to its concrete type with a pointer cast. The casts are aligned, so mark them with targeted `#[expect]` attributes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Turn quoted doc links into real intra-doc links where a target exists, and wrap array examples and SQL snippets in backticks or text code fences. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Change internal fn parameters and return types from `&Option<T>` to `Option<&T>`, updating callers to pass `.as_ref()`. Also changes the public `apply_masking` in datafusion-substrait, which forwards from a flagged internal fn. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Drop `continue` expressions that end a loop iteration anyway, flattening the surrounding `match`/`if` where that reads better. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Use `Iterator::copied`/`Option::copied` instead of `cloned` for `Copy` types. Applied with `cargo clippy --fix`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Drop semicolons after `match`/`if` expressions in tail position. Applied with `cargo clippy --fix`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Drop trailing commas after single-item non-tuple parens/brackets. Applied with `cargo clippy --fix`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
emilk
force-pushed
the
emilk/enable-more-clippy-lints-2
branch
from
3965bd2 to
c0eb49d
Compare
August 24, 2026 09:54
Copy link
Copy Markdown
Contributor
Author
|
I'd love to, but want this PR merged first! |
Sorry, something went wrong.
Conflicts: * `operator_statistics/mod.rs`: upstream replaced the provider loop that the `needless_continue` fix touched, so the loop is gone; took upstream. * `topk/mod.rs`: upstream re-indexed `equal_indices` to the gathered sub-batch; kept that and dropped the `continue` per `needless_continue`. New upstream code that trips the lints this branch enables: * `joins/utils.rs`: `&Option<RecordBatch>` -> `Option<&RecordBatch>` (`ref_option`) * `hash_utils.rs`: `cloned` -> `copied` (`cloned_instead_of_copied`) * `statistics_order_tests.rs`: trailing comma (`unnecessary_trailing_comma`) * `fixed_size_binary_filter.rs`, `in_list_strategy.rs`: `#[expect]` for the alignment-check casts (`cast_ptr_alignment`) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Continuing #24466: turn on more clippy::pedantic lints (opt-out list in Cargo.toml).
What changes are included in this PR?
One commit per lint, each removing its "allow" line from Cargo.toml
and fixing every site. Review one commit at a time!
Let me know if you disagree with any and I'll revert it
The ref_option commit also changes the signature of the public apply_masking fn in datafusion-substrait (&Option<MaskExpression> -> Option<&MaskExpression>), since it forwards to an internal fn that was flagged.
Are these changes tested?
cargo clippy --workspace --all-targets --all-features reports no
warnings. The changes are mechanical and behavior-preserving, so no new
tests.
Are there any user-facing changes?
The ref_option commit changes the public apply_masking signature in
datafusion-substrait, see above.