Fix panic on RightMark hash joins when propagating ordering - #24718
Merged
alamb merged 1 commit intoAug 27, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
`maintains_input_order` has been changed to also return `true` on `RightMark` but this function has not been updated Close apache#24717
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #24718 +/- ##
==========================================
- Coverage 81.45% 81.45% -0.01%
==========================================
Files 1120 1120
Lines 401289 401289
Branches 401289 401289
==========================================
- Hits 326871 326866 -5
- Misses 55295 55300 +5
Partials 19123 19123 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
alamb
approved these changes
Aug 27, 2026
Comment thread
datafusion/physical-optimizer/src/ensure_requirements/enforce_sorting/sort_pushdown.rs
| JoinType::RightSemi | JoinType::RightAnti | JoinType::RightMark => { | ||
| map_fields(plan.right().schema(), JoinSide::Right) | ||
| } | ||
| _ => unreachable!("unexpected join type: {}", plan.join_type()), |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
To make this more defensive, it would be great to make this unreachable into an internal error
Sorry, something went wrong.
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Fixes a panic in enforce_sorting when given a RightMark hash join: HashjoinExec::maintains_input_order has been changed to also return true on RightMark but enforce_sorting has not been updated
What changes are included in this PR?
Adds support of RightMark joins to enforce_sorting they keep the input sorting.