| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Follow-up (no action needed before merging this PR): the new Javadoc on disableSpill() and maxTempDirectorySize(long) describes the failure case as "a RuntimeException carrying DataFusion's resources-exhausted message" because the typed exception hierarchy from #79 (feat/typed-exceptions) isn't on this branch's base. Once #79 merges, a one-line follow-up can tighten both Javadoc references to {@link ResourcesExhaustedException} for accurate cross-linking. If #79 merges first, this PR's Javadoc can be updated during a rebase before merge instead. |
Sorry, something went wrong.
Sure, resolving |
Sorry, something went wrong.
…uilder # Conflicts: # core/src/main/java/org/apache/datafusion/SessionContextBuilder.java # proto/session_options.proto
… ResourcesExhaustedException + add test
@andygrove conflicts resolved and the follow-up included. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Which issue does this PR close?
Rationale for this change
PR #28 added tempDirectory(String) as the only Java surface for DataFusion's RuntimeEnvBuilder disk-manager knobs. Two real gaps remain — both reachable on the Rust side, neither reachable from Java today, and neither reachable via setOption(...) because they live on RuntimeEnv construction rather than the datafusion.* config namespace (the native side already explicitly rejects datafusion.runtime.* keys, for the same reason that motivated the existing typed memoryLimit(...) / tempDirectory(...) setters):
Issue #83 originally included a third setter, tempDirectories(List<String>), but a follow-up survey of the upstream code, CLI, docs, examples, and Python binding showed multi-directory mode is a programmatic-only escape hatch on DiskManagerBuilder: not exposed by RuntimeEnvBuilder itself, not used by datafusion-cli, not in configs.md, not in any example. It can ship later if a real user files an issue with a use case; punting it keeps this PR focused on the two setters with concrete motivation.
What changes are included in this PR?
Are these changes tested?
Yes. 9 new tests in SessionContextBuilderTest
Are there any user-facing changes?
Yes, additive only — no breaking changes.