Export to_datafusion_err from the util crate root - #1487
Merged
kosiew merged 4 commits intoMay 29, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Publicly re-export curated error helpers, including to_datafusion_err, from the crate root. Add a regression test in crates/util/tests/root_exports.rs to ensure correct functionality in an integration-test context.
Make only to_datafusion_err publicly re-exported from the crate root. Keep PyDataFusionError and PyDataFusionResult as private imports for internal use, enhancing encapsulation and reducing exposure of non-essential components.
kosiew
marked this pull request as ready for review
May 8, 2026 05:18
10 tasks
timsaucer
approved these changes
May 27, 2026
timsaucer
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I recommend removing that test. I don't think it adds a lot of value.
Sorry, something went wrong.
Comment thread
crates/util/tests/root_exports.rs
Outdated
Comment on lines
+18
to
+23
| use datafusion_python_util::to_datafusion_err; | ||
|
|
||
| #[test] | ||
| fn exports_to_datafusion_err_from_crate_root() { | ||
| let _ = to_datafusion_err("importable from crate root"); | ||
| } |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This feels unnecessary.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@timsaucer |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Users currently cannot import to_datafusion_err directly from datafusion_python_util, even though the function is already public in errors.rs. This creates an inconsistency between the function’s visibility and how consumers expect to access it from the crate root.
This change fixes that mismatch by re-exporting to_datafusion_err from lib.rs, making the crate’s public API behave as expected and resolving the private item import error reported in the issue.
What changes are included in this PR?
This PR makes a small public API cleanup in the util crate:
Are these changes tested?
Yes.
This PR adds a regression test, exports_to_datafusion_err_from_crate_root, which imports to_datafusion_err from datafusion_python_util and verifies that the symbol is available from the crate root. This helps prevent future regressions in the crate’s public exports.
Are there any user-facing changes?
Yes.
to_datafusion_err is now importable directly from the datafusion_python_util crate root:
This is a small user-facing API improvement, but it is not a breaking change.
LLM-generated code disclosure
This PR includes code, comments generated with assistance from LLM. All LLM-generated content has been manually reviewed and tested.