FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[DataFrame] - Add DataFrame::distinct binding by francis-du · Pull Request #34 · apache/datafusion-python · GitHub

[DataFrame] - Add DataFrame::distinct binding - #34

Merged
andygrove merged 3 commits into
apache:masterfrom
francis-du:df_distinct_fun
Sep 8, 2022
Merged

[DataFrame] - Add DataFrame::distinct binding#34
andygrove merged 3 commits into
apache:masterfrom
francis-du:df_distinct_fun

Conversation

Copy link
Copy Markdown
Contributor

Close #29

Copy link
Copy Markdown
Member

Thanks @francis-du! It looks like there is a Clippy issue on all of these PRs.

Copy link
Copy Markdown
Member

There are clippy failures like this - not related to your changes:

4 |         default_catalog: &str,
   |                          ^ help: if you would like to reborrow, try removing `&*`: `&`

I saw these recently on another project. We probably need to switch to using String instead of &str in pyo3 methods. Not sure why we are suddenly seeing this now though.

francis-du commented Aug 19, 2022
edited
Loading

Copy link
Copy Markdown
Contributor Author

This is a new lint in release 1.63.0
https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref

I will reopen a new PR to fix this issue

Copy link
Copy Markdown
Member

@francis-du could you merge latest from master on these PRs? I fixed the clippy issue

Copy link
Copy Markdown
Contributor Author

@francis-du could you merge latest from master on these PRs? I fixed the clippy issue

OK 👌

Copy link
Copy Markdown
Member

Looks like a linting issue

Copy link
Copy Markdown
Contributor Author

Looks like a linting issue

It has been fixed, please review

Copy link
Copy Markdown
Member

Thanks @francis-du!

andygrove merged commit d083d97 into apache:master Sep 8, 2022
francis-du deleted the df_distinct_fun branch November 11, 2022 18:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Python binding for DataFrame::distinct

2 participants


Back | FazBrowse Home | New Git URL