FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[Feature][Lake] Add bulk scope config apply and cross-connection scope config sharing by bujjibabukatta · Pull Request #8922 · apache/devlake · GitHub

/ devlake Public

[Feature][Lake] Add bulk scope config apply and cross-connection scope config sharing - #8922

Open
bujjibabukatta wants to merge 2 commits into
apache:mainfrom
bujjibabukatta:fix/#8896
ConversationCommits (2)ChecksFiles changed
Open

[Feature][Lake] Add bulk scope config apply and cross-connection scope config sharing#8922
bujjibabukatta wants to merge 2 commits into
apache:mainfrom
bujjibabukatta:fix/#8896

Conversation

bujjibabukatta commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #8896

This PR implements two related feature requests to improve scope config
management for users maintaining multiple projects/connections in a single
DevLake instance.

Changes

Feature 1 — Multi-select data scopes with bulk scope config apply

File: config-ui/src/routes/blueprint/connection-detail/table.tsx

  • Added checkbox row selection to the data scope table
  • Added a bulk action toolbar that appears when rows are selected, showing:
    • Selected count badge
    • "Apply Scope Config to Selected" button
    • "Clear Selection" button
  • Clicking the button opens a scope config picker modal
  • The chosen scope config is applied to all selected data scopes in parallel
    via existing PATCH /plugins/{plugin}/connections/{connectionId}/scopes/{scopeId}

Feature 2 — Share scope configs across connections

File: config-ui/src/plugins/components/scope-config-select/index.tsx
File: config-ui/src/api/scope-config/index.ts

  • Added listAll API function to fetch scope configs across all connections
    for a plugin
  • Added "This Connection Only / Showing: All Connections" toggle button in
    the scope config picker
  • Users can now reuse an existing scope config from any connection instead
    of recreating it each time

How to Test

  1. Go to a Project → Blueprint → Connection detail page
  2. Select multiple data scopes using the checkboxes
  3. Click "Apply Scope Config to Selected" and pick a config → all selected
    scopes should be updated
  4. Click "Associate Scope Config" on any single scope → toggle
    "This Connection Only" to "Showing: All Connections" → configs from
    all connections should appear in the list

No Backend Changes Required

The existing ListScopeConfigs backend handler already returns all scope
configs without filtering by connection_id. The frontend now exposes
this via the toggle.

albusshirazi suggested changes Jun 13, 2026
View reviewed changes
Comment thread config-ui/src/plugins/components/scope-config-select/index.tsx Outdated
[data, scopeConfigId],
);
const dataSource = useMemo(() => {
const filtered = showAll ? data : data;

albusshirazi Jun 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The ternary operator evaluates to data in both the true and false cases. This means showAll has no actual effect, and filtered will always just be data.
Did you forget to add the filtering logic here? If showAll is false, it should probably return a filtered subset of data rather than the whole array. If no filtering is intended yet, you can remove this ternary and the showAll dependency to keep it clean.

bujjibabukatta commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

Hi @albusshirazi

Thanks for the feedback. You're right — the ternary expression was effectively redundant since both branches returned the same data.

I've removed the unnecessary ternary and the showAll dependency from the memo. The filtering logic is already handled server-side in useRefreshData, which switches between listAll and list based on the value of showAll, so no additional client-side filtering is required here.

I've pushed the changes. Could you please take another look and let me know if everything looks good?

albusshirazi reviewed Jun 13, 2026
View reviewed changes
Comment thread config-ui/src/plugins/components/scope-config-select/index.tsx Outdated
const dataSource = useMemo(
() => (data ? (scopeConfigId ? [{ id: 'None', name: 'No Scope Config' }].concat(data) : data) : []),
[data, scopeConfigId],
[data, scopeConfigId, showAll],

albusshirazi Jun 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks much better! Moving the showAll check into the data fetcher clarifies the intent perfectly.

​Just one minor cleanup detail on line 49:
[data, scopeConfigId, showAll],
​You can remove showAll from this dependency array. Since showAll is no longer referenced inside the useMemo callback on line 48, keeping it in the array is unnecessary and will flag a React hooks exhaustive-deps linting warning.

albusshirazi reviewed Jun 13, 2026
View reviewed changes

albusshirazi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

klesh commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Good work!
Could you please attach some screenshots to demonstrate the design? Thanks

bujjibabukatta commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

Hey @klesh, honest answer — I'm not able to share screenshots right now and I hope that's okay. The good news is there's genuinely nothing visually surprising here — every component is something already in the codebase, antd Table, existing modal, standard buttons, just connected together to solve a real user problem. No new design, no backend changes, clean and contained. I've put real care into this one and I'd really appreciate your trust to get it merged

klesh commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Hey @klesh, honest answer — I'm not able to share screenshots right now and I hope that's okay. The good news is there's genuinely nothing visually surprising here — every component is something already in the codebase, antd Table, existing modal, standard buttons, just connected together to solve a real user problem. No new design, no backend changes, clean and contained. I've put real care into this one and I'd really appreciate your trust to get it merged

This is not about you, or trust. I am not familiar with the FE so it is hard for me to understand the change.
I have to be responsible for what I merge, I can merge if you could help me here or wait for someone who familiar with this part of the system to review the code.

bujjibabukatta commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Hi @albusshirazi could you please approve and merge pull request ?

albusshirazi commented Jun 23, 2026

Copy link
Copy Markdown

I agree with @klesh - please add screenshots explaining the change (I read the changes, there are not a lot but they do affect the ui&ux of Devlake and I think more sets of eyes should view them)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
albusshirazi albusshirazi requested changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature][Lake] Improve scope config functionalities

3 participants

Back | FazBrowse Home | New Git URL