Fix Copilot seat organization attribution causing wrong DORA adoption denominator - #9049
Fix Copilot seat organization attribution causing wrong DORA adoption denominator#9049bramhanandlingala wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
Thank you for creating a PR so quickly and for helping me investigate this issue. Does this fix seats assigned through a central licensing organization? The change stores seat.organization.login, which appears to identify the organization assigning the seat. If Central Licensing Org assigns a seat to a user who belongs to Product Org A and Product Org B, GitHub attributes usage to both product organizations, but the seat may remain attributed only to Central Licensing Org. Would Product Org A and Product Org B still have zero denominators? Should licensed users be joined with organization membership, and could this scenario be added as a test? |
Sorry, something went wrong.
|
@anthonyhull-ford Thanks for looking into this closely — good catch. You're right that this doesn't cover centrally-licensed seats. I checked GitHub's docs, and when a seat is licensed through multiple orgs in the same enterprise, GitHub bills (and reports) only one org per seat, chosen by GitHub — so the seats API itself never exposes the user's other org memberships. That means Product Org A and B could still show zero denominators in that case, but it's not fixable from this endpoint alone; it'd need a separate join against org membership data. I'd like to keep that as a follow-up rather than block this fix, since it's a different data source and a bigger scope. Also — noticed the CI checks aren't triggering on this PR. Could someone approve the workflow run? |
Sorry, something went wrong.
Reviewers
At least 1 approving review is required to merge this pull request.
Summary
Fixes #9041. Copilot seats from GitHub's enterprise API were being
tagged with the connection's "shell" org instead of the org that
actually granted the seat, which made the DORA dashboard's adoption
percentage wrong (often zero) for any org besides the shell org. Two
dashboard queries also mislabeled NULL adoption as the highest tier
instead of excluding it.
Root cause
connection.Organization, ignoring the per-seat organization
field the enterprise seats endpoint actually returns.
a catch-all, so NULL adoption silently got labeled >75% / high
instead of being excluded.
Fix
(metrics_extractor.go) and prefer it over the connection's
configured org, falling back only when the API doesn't supply one
(seat_extractor.go).
both dashboards' tier queries (MySQL and PostgreSQL).
tests covering org-scoped, enterprise-with-org, and
enterprise-with-empty-org cases.
Closes #9041