fix(gitlab): use stateful extractors for users and tags - #9070
Merged
klesh merged 2 commits intoSep 1, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
NewApiExtractor always deleted tool-layer rows by raw params before insert, so a truncated Collect Users run wiped accounts. NewStatefulApiExtractor upserts incrementally, matching the rest of the GitLab plugin. Co-Authored-By: Cursor Grok 4.6 <noreply@example.com> Co-authored-by: Cursor <cursoragent@cursor.com>
mfrancisc
added a commit
to mfrancisc/devlake
that referenced
this pull request
Aug 25, 2026
Upstream-Status: Submitted Co-Authored-By: Cursor Grok 4.6 <noreply@example.com> Co-authored-by: Cursor <cursoragent@cursor.com>
klesh
approved these changes
Sep 1, 2026
Copy link
Copy Markdown
Contributor
|
LGTM, Thanks for your contribution. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitLab Extract Users and Extract Tags were the last GitLab extractors still using the deprecated NewApiExtractor. That helper always deletes tool-layer rows by _raw_data_table + _raw_data_params before insert.
On self-hosted GitLab, Collect Users can stop early when a page is shorter than pageSize (fetchPagesUndetermined) and still return success. The following Extract Users run then wipes accounts that project last wrote and keeps only the partial dump.
This switches both extractors to NewStatefulApiExtractor, matching MRs, notes, pipelines, and jobs: