FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Introduced maven wrapper and simple travisci build script by gbatalski · Pull Request #11 · apache/directory-ldap-api · GitHub

Introduced maven wrapper and simple travisci build script - #11

Open
gbatalski wants to merge 2 commits into
apache:masterfrom
gbatalski:mvnwrapper-travisci
Open

gbatalski wants to merge 2 commits into
apache:masterfrom
gbatalski:mvnwrapper-travisci

Conversation

Copy link
Copy Markdown
Contributor
  • For simpler builds and CI scenarios it is helpful to use maven wrapper
  • Initial travisci script for alternative CI pipelines, which allows contributors to test changes without on-premise infrastructure, introduced

gbatalski added 2 commits May 4, 2019 12:49
Signed-off-by: Ghenadii Batalski <Ghenadii.Batalski@gmail.com>
Signed-off-by: Ghenadii Batalski <Ghenadii.Batalski@gmail.com>

seelmann commented May 5, 2019

Copy link
Copy Markdown
Member

Nice to introduce the possibility to run a Travis CI build.
I just wonder if we should introduce the maven wrapper. For our Jenkins pipeline (see Jenkinsfile and https://builds.apache.org/blue/organizations/jenkins/dir-ldap-api-pipeline/activity/) we now use Docker with a custom image (see https://github.com/apache/directory-buildtools/tree/master/docker/maven-build) that includes Java and Maven. I think this can easily be used for the Travis CI build too.

gbatalski commented May 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

With maven wrapper one doesn't even need to have docker or maven installed: only the jdk. For an opensource project i think, travis ci is a very nice and simple integration solution. The maven wrapper would simplify the test environment even more. The setup i propose works just fine and is very simple (https://travis-ci.org/gbatalski/directory-ldap-api/builds/528122540) especially for occasionally contributor like me. The needless complexity of jenkins setup looks to me just not state-of-the-art.

Copy link
Copy Markdown
Contributor

I'm willing to merge this RC, but I have one question: does it impact the existing code and build in any way ? Also we need to maintain this wrapper in the long run, that would require a minimum documentation for us to get a grip on this piece of code.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL