FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ut Fix DiskUtilsTest runs failed on mac by Andersuc · Pull Request #50981 · apache/doris · GitHub

/ doris Public

ut Fix DiskUtilsTest runs failed on mac - #50981

Merged
yiguolei merged 3 commits into
apache:masterfrom
Andersuc:fix_fe_test
May 19, 2025
ConversationCommits (3)ChecksFiles changed
Merged

ut Fix DiskUtilsTest runs failed on mac#50981
yiguolei merged 3 commits into
apache:masterfrom
Andersuc:fix_fe_test

Conversation

Andersuc commented May 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

ut location in "fe/fe-common/src/test/java/org/apache/doris/common/io/DiskUtilsTest.java:54 "
running the faild ut "cd fe && mvn test -Dtest=DiskUtilsTest"

As mac os has no vitual directory ‘/proc' , so will run failed
"""
running this command(df -k /proc) on mac os
df -k /proc
df: /proc: No such file or directory

"""

So we use "/" directory , which will be success both on linux and mac os

Thearas commented May 16, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Andersuc commented May 17, 2025

Copy link
Copy Markdown
Contributor Author

run buildall

doris-robot commented May 17, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 34023 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b5e7a07df614e2e549b089f25e1cedbcee28587e, data reload: false

------ Round 1 ----------------------------------
q1	26127	5093	5015	5015
q2	2063	268	171	171
q3	10427	1241	706	706
q4	10247	992	521	521
q5	7520	2339	2344	2339
q6	180	162	132	132
q7	893	750	631	631
q8	9447	1258	1084	1084
q9	7137	5221	5199	5199
q10	6990	2337	1931	1931
q11	504	289	270	270
q12	360	364	223	223
q13	18139	3722	3068	3068
q14	228	225	205	205
q15	528	500	490	490
q16	426	433	391	391
q17	597	855	363	363
q18	7503	7216	7171	7171
q19	1676	940	556	556
q20	332	320	222	222
q21	3656	3229	2392	2392
q22	1074	1002	943	943
Total cold run time: 116054 ms
Total hot run time: 34023 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5141	5047	5017	5017
q2	234	326	229	229
q3	2137	2630	2317	2317
q4	1400	1809	1419	1419
q5	4420	4368	4344	4344
q6	220	169	126	126
q7	1998	1913	1746	1746
q8	2540	2526	2467	2467
q9	7232	7134	7111	7111
q10	3017	3171	2751	2751
q11	580	506	508	506
q12	678	800	630	630
q13	3501	3902	3339	3339
q14	288	282	264	264
q15	536	482	472	472
q16	444	496	429	429
q17	1141	1552	1385	1385
q18	7688	7568	7378	7378
q19	818	843	1063	843
q20	1904	1992	1830	1830
q21	4852	4486	4366	4366
q22	1110	1070	1016	1016
Total cold run time: 51879 ms
Total hot run time: 49985 ms

doris-robot commented May 17, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 193581 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b5e7a07df614e2e549b089f25e1cedbcee28587e, data reload: false

query1	1415	1096	1088	1088
query2	6188	1811	1810	1810
query3	11038	4512	4438	4438
query4	53229	25802	23473	23473
query5	5160	519	456	456
query6	337	207	209	207
query7	4873	530	298	298
query8	322	268	245	245
query9	5324	2708	2710	2708
query10	442	343	276	276
query11	15254	15026	14795	14795
query12	159	112	105	105
query13	1044	540	445	445
query14	9981	6325	6462	6325
query15	206	204	181	181
query16	7146	640	486	486
query17	1096	740	594	594
query18	1590	428	325	325
query19	214	210	188	188
query20	134	130	123	123
query21	205	129	108	108
query22	4533	4466	4534	4466
query23	34378	33630	33660	33630
query24	6576	2420	2404	2404
query25	465	488	406	406
query26	714	269	165	165
query27	2298	527	349	349
query28	3055	2210	2194	2194
query29	582	591	433	433
query30	289	220	220	220
query31	880	879	786	786
query32	74	61	60	60
query33	462	407	312	312
query34	821	875	538	538
query35	814	819	757	757
query36	942	1009	920	920
query37	110	106	82	82
query38	4232	4324	4217	4217
query39	1553	1472	1647	1472
query40	208	125	108	108
query41	55	55	52	52
query42	132	110	119	110
query43	505	532	499	499
query44	1379	874	890	874
query45	184	178	169	169
query46	884	1030	659	659
query47	1865	1890	1831	1831
query48	423	461	354	354
query49	687	531	450	450
query50	678	690	416	416
query51	4205	4248	4345	4248
query52	113	112	101	101
query53	232	259	197	197
query54	600	605	524	524
query55	92	90	89	89
query56	315	313	301	301
query57	1208	1232	1131	1131
query58	283	265	251	251
query59	2709	2771	2682	2682
query60	338	334	329	329
query61	132	122	135	122
query62	683	742	649	649
query63	251	193	187	187
query64	1783	1041	668	668
query65	4302	4241	4201	4201
query66	718	406	312	312
query67	16306	15584	15481	15481
query68	7490	892	545	545
query69	552	303	279	279
query70	1214	1138	1067	1067
query71	498	320	303	303
query72	5968	4868	4823	4823
query73	1484	660	376	376
query74	8994	9142	8837	8837
query75	3899	3191	2663	2663
query76	4190	1201	754	754
query77	632	381	289	289
query78	10043	10305	9340	9340
query79	1955	800	666	666
query80	593	512	448	448
query81	489	253	220	220
query82	453	128	97	97
query83	255	245	234	234
query84	298	101	86	86
query85	780	349	311	311
query86	376	302	276	276
query87	4457	4467	4286	4286
query88	3712	2431	2408	2408
query89	416	313	277	277
query90	1957	204	202	202
query91	151	145	116	116
query92	75	63	57	57
query93	1077	948	585	585
query94	679	414	299	299
query95	375	284	277	277
query96	561	573	295	295
query97	2754	2780	2617	2617
query98	233	209	198	198
query99	1518	1364	1270	1270
Total cold run time: 297533 ms
Total hot run time: 193581 ms

doris-robot commented May 17, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 28.92 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b5e7a07df614e2e549b089f25e1cedbcee28587e, data reload: false

query1	0.04	0.04	0.02
query2	0.12	0.10	0.12
query3	0.24	0.19	0.19
query4	1.59	0.20	0.18
query5	0.46	0.44	0.44
query6	1.47	0.66	0.67
query7	0.02	0.01	0.02
query8	0.04	0.03	0.04
query9	0.57	0.51	0.52
query10	0.57	0.57	0.57
query11	0.15	0.12	0.11
query12	0.14	0.12	0.12
query13	0.62	0.60	0.60
query14	0.79	0.80	0.81
query15	0.87	0.84	0.87
query16	0.38	0.38	0.38
query17	1.02	1.04	1.04
query18	0.22	0.21	0.21
query19	1.98	1.75	1.90
query20	0.02	0.00	0.01
query21	15.40	0.89	0.55
query22	0.76	1.23	0.76
query23	14.74	1.36	0.62
query24	7.32	1.46	0.64
query25	0.45	0.28	0.12
query26	0.68	0.16	0.13
query27	0.05	0.06	0.04
query28	9.17	0.89	0.44
query29	12.52	3.93	3.26
query30	0.25	0.10	0.08
query31	2.81	0.61	0.38
query32	3.24	0.56	0.47
query33	3.13	3.10	3.07
query34	15.79	5.14	4.50
query35	4.51	4.50	4.55
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.17	0.14	0.14
query41	0.08	0.03	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 103.28 s
Total hot run time: 28.92 s

github-actions Bot commented May 18, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

github-actions Bot added approved Indicates a PR has been approved by one committer. reviewed labels May 18, 2025

github-actions Bot commented May 18, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

dataroaring approved these changes May 18, 2025
View reviewed changes

dataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

yiguolei merged commit 09107db into apache:master May 19, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
ut Fix DiskUtilsTest runs failed on mac (apache#50981)
9a0adeb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yiguolei yiguolei approved these changes
dataroaring dataroaring approved these changes
+1 more reviewer
wyxxxcat wyxxxcat approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL