Remove the need to call the PropsUi.setLook() #2638 - #7592
Draft
nadment wants to merge 1 commit into
Draft
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
It's currently a proof of concept, but it works well on Windows (39 calls to setTheme vs. 8,000 calls to setLook). However, we need to remember to use setTheme() for a control that changes dynamically. I think I've updated many places, but we might still find others. Calls to the PropsUi.setLook() function haven't been removed yet, but these functions no longer do anything. I'd like some help figuring out how this behaves on other operating systems.
Copy link
Copy Markdown
Contributor
|
Could you check the font where we want fixed width like JavaScript, SQL, and so on? 
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's currently a proof of concept, but it works well on Windows (39 calls to setTheme vs. 8,000 calls to setLook).
However, we need to remember to use setTheme() for a control that changes dynamically. I think I've updated many places, but we might still find others.
Calls to the PropsUi.setLook() function haven't been removed yet, but these functions no longer do anything.
I'd like some help understanding how this works on other operating systems.