| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Codecov Report❌ Patch coverage is 49.53271% with 54 lines in your changes missing coverage. Please review. @@ Coverage Diff @@
## master #3159 +/- ##
============================================
- Coverage 37.72% 37.72% -0.01%
- Complexity 6521 6529 +8
============================================
Files 800 800
Lines 68821 68882 +61
Branches 9127 9147 +20
============================================
+ Hits 25965 25988 +23
- Misses 39815 39844 +29
- Partials 3041 3050 +9 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Why this branch contains PD Raft changesThe PD change in 3d9d9544 is independent of the REST API 0.72 bump. It was identified while preparing the real 3-PD distributed matrix, where PD peers use stable hostnames but container/Pod IPs may change after restart or membership updates. Before:
After:
Most of the apparent size is defensive behavior and tests: this commit is +1375/-226, including about 700 added test lines and relocation/expansion of the old IpAuthHandlerTest. Scope note: this is not required to distinguish API 0.71 from 0.72, nor by the Hubble permission capability itself. It should be reviewed as a standalone PD reliability/security change (and preferably split from the API-version PR). Passing tests do not replace the pending final 3+3+3 runtime validation. Scope freezeThe Hubble dependency is limited to the API 0.72 contract and the GraphSpace-wide default-role behavior. The PD Raft DNS/IP work is independent and must not grow further except for a blocker reproduced by the required 3+3+3 runtime. It should remain separately reviewable/splittable from the Hubble compatibility change. |
Sorry, something went wrong.
There was a problem hiding this comment.
Blocking: yes. Summary: No actionable code defect was independently confirmed at this head. Approval remains blocked by the current codecov/project failure. Evidence: Java 11 targeted tests passed: PD auth/raft 20/20, PDService raft update 6/6, GraphSpace API 13/13; current checks show codecov/project FAILURE.
Sorry, something went wrong.
Bring in server REST API 0.72 changes (PR apache#3159) for local Hubble auth testing.
There was a problem hiding this comment.
Blocking: yes. Summary: The new Gremlin mutation pre-check misses TinkerPop merge steps, so execute-only users can reach mutation paths without a required WRITE check. Evidence: traversalPermissions() only recognizes AddVertexStartStep, AddVertexStep, AddEdgeStartStep, AddEdgeStep, AddPropertyStep, and DropStep at HugeGraphAuthProxy.java:2533-2541; TinkerPop 3.7.6 also has MergeVertexStep and MergeEdgeStep, whose on-match path can call Vertex.property directly. Please classify both merge steps as WRITE (including nested children) and add execute-only regression tests for mergeV/mergeE create and onMatch cases.
Sorry, something went wrong.
There was a problem hiding this comment.
Blocking: yes. Summary: The current head has authorization correctness and isolation regressions in GraphSpace role checks, Gremlin mutation enforcement, and callback context cleanup. Evidence: exact-head static review plus six independent read-only lanes; latest checks pass for builds/Docker/CodeQL, while dependency-review is cancelled and Codecov failures are non-blocking.
Sorry, something went wrong.
|
Superseded by hugegraph#198. The reviewed fixes and remaining compatibility acceptance are now tracked in the organization repository; please close this ASF PR. |
Sorry, something went wrong.
- keep membership roles out of data action matching - preserve explicit read write and delete permissions - verify members can read without gaining mutations - retain direct GraphSpace administrator handling
- initialize audit limiter only after successful authentication - keep failed password and token attempts out of limiter state - invalidate limiter entries by username when deleting users - remove PD dynamic DNS and IP refresh from this PR - cover password token and cleanup paths with unit tests
- run metadata callbacks with an internal admin context - restore the previous context on success or failure - prevent admin propagation into callback child threads - cover task override and context restoration boundaries
- allow space managers to inspect users in their own space - reject users without current-space grants and global admins - cover cross-space and multi-space permission boundaries
- recognize custom global admins for user updates - allow custom global admins to delete ordinary users - preserve builtin admin behavior and deletion safeguards - cover builtin and custom admin mutation paths
- align template ownership with global admin semantics - preserve creator and GraphSpace manager access - cover all four template management roles
- align Checkstyle and EditorConfig at 120 columns - update contributor and module style guidance - compact only current PR code without legacy reformatting
- defer authenticator lookup until manager access is needed - keep anonymous creators on the owner mutation path - cover lazy owner and manager authorization paths
- recognize mergeV and mergeE as write operations - preserve compatibility with the current TinkerPop baseline - reject execute-only create and onMatch traversals - verify recursive child traversal permissions
- match merge steps by exact TinkerPop class names - retain superclass traversal for provider implementations - reject unrelated steps sharing merge simple names - preserve recursive child permission coverage
- add pinned-3.5 test fixtures for TinkerPop merge steps - route vertex and edge merge shapes through strategy checks - retain external same-name and child traversal regressions
- move compatibility fixtures into test output only - add test output to the unit-test classpath - construct exact-package fixtures reflectively - keep main artifacts free of TinkerPop shadow classes
- select fixture sources from the pinned TinkerPop version - keep 3.5.1 compatibility classes in test output only - stop selecting fixtures automatically after a version change - preserve merge permission regression coverage
- prefer the official traversal and isStart constructor - use Merge.onMatch through reflection when available - keep an explicit 3.5.1 fixture child fallback - preserve merge authorization coverage
- restore the TinkerPop 3.5.1 authorization scope\n- remove future-version merge detection and fixtures\n- keep the Hubble permission closeout focused on reproduced behavior
- move dependency review action from v3 to the Node 24 v5 release - use the supported oversized-summary handling - keep existing severity and license policy unchanged
- add a configurable PD Raft whitelist toggle - preserve whitelist behavior by default - skip the IP handler when disabled
- use username consistently for audit limiter lookup - cover distinct user id and username cleanup - verify PD IP whitelist switch pipeline behavior
- honor ALL_GRAPHS and reject mixed-space grants - make callback elevation explicit and restore request contexts - remove incomplete Gremlin and legacy observer compatibility paths - preserve HStore clear safety and the HBase Docker trigger
|
TODO follow-ups intentionally kept out of this minimal API 0.72 closeout:
These are explicit follow-ups, not silently implemented compatibility behavior |
Sorry, something went wrong.
|
Final dependency-review rerun note: attempt 3 completed with the same stale all-dependencies-added snapshot and failed on existing vulnerable/low-score packages. The PR changes no dependency coordinates; its only pom.xml delta changes the API JAR Implementation-Version from 0.71.0.0 to 0.72.0.0. The repository-specific dependency-check job passes, all build/storage/Docker jobs pass, and Codecov patch/project pass. This dependency-review result is classified as a base-snapshot failure rather than a current-head dependency regression; no product or dependency suppression change is made. |
Sorry, something went wrong.
- identify the GraphSpace default-role change as PR-3159 - keep the existing API 0.72 contract description - leave runtime version behavior unchanged
| Back | FazBrowse Home | New Git URL |
Closeout status
and the runtime version endpoint.
future graphs.
succeeds without a warm-up request.
disclosure.
restore every auth, request GraphSpace and task context.
request-time legacy observer migration/cleanup.
cache invalidation.
Before → After
Final-head evidence
is explicitly tracked in the consolidated TODO rather than expanded here
Approval and merge remain upstream review gates, not claims of this closeout.