Infra: Require CI checks before auto-merge - #3832
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s CI/merge infrastructure so GitHub auto-merge cannot merge a PR until merge-critical workflows have actually produced the expected check contexts.
Changes:
- Removes pull_request.paths filters from key workflows so they always run on PRs (preventing “required check pending because workflow was skipped”).
- Adds an explicit required_status_checks.contexts allowlist for main in .asf.yaml to require specific CI check contexts before merging.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/python-integration.yml | Removes PR path filters so integration suites always run on PRs. |
| .github/workflows/python-ci.yml | Removes PR path filters so unit/lint/Windows/smoke checks always run on PRs. |
| .github/workflows/check-md-link.yml | Removes PR path filters so markdown link checking runs on all PRs. |
| .asf.yaml | Explicitly enumerates required CI check contexts for branch protection / auto-merge gating. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
rambleraptor
left a comment
There was a problem hiding this comment.
This will increase our runner usage for non-code changes. Most of our PRs are code related, so this is hopefully a wash.
Sorry, something went wrong.
Reviewers
+1 more reviewerAt least 1 approving review is required to merge this pull request.
Rationale for this change
PR #3815 enabled auto-merge, but main has no required status-check contexts. Adding them is necessary for two reasons:
When a pull_request path filter skips an entire workflow, GitHub does not report its check. Branch protection then waits indefinitely for that required check, preventing auto-merge. Removing the path filters ensures every required check reports a result on every PR.
Are these changes tested?
Yes. Workflow linting, YAML validation, and commit hooks pass.
Are there any user-facing changes?
No.