Bundle headers: state that the bun-built bundles embed third-party npm packages - #234
Open
pjfanning wants to merge 2 commits into
Open
pjfanning wants to merge 2 commits into
pjfanning wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…m packages util/upload.js, util/config/configurator.js and admin/usage/usage.js are bun build outputs. Each carried only the standard ASF licence header, which misrepresents the file: most of upload.js is third-party MIT, ISC, BSD-3-Clause and Apache-2.0 code from npm. Keep the ASF header for the ASF-authored part and add a second block naming the embedded packages and their licences, pointing to LICENSE for copyright holders and licence texts. The ASF header block is unchanged, so Apache RAT and license-eye still approve the files (RAT 0.18: Unapproved 0). Bundles still parse. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The three bun build outputs checked into this repo carried only the standard ASF licence header:
That header misrepresents the files. Most of upload.js is third-party code from npm: minio (Apache-2.0), 24 MIT packages (lodash, async, xml2js, readable-stream, ...), inherits and sax (ISC), stream-json (BSD-3-Clause). The configurator embeds @clack/core, @clack/prompts, sisteransi (MIT) and picocolors (ISC); usage.js embeds yaml (ISC).
This PR keeps the ASF header for the ASF-authored part of each bundle and adds a second comment block naming the embedded packages grouped by licence, pointing to LICENSE for copyright holders and licence texts, and noting the file is generated.
Checks
Related
🤖 Generated with Claude Code