Replace ingress and cert-manager manifests with pinned Helm charts - #235
Open
miki3421 wants to merge 1 commit into
Open
miki3421 wants to merge 1 commit into
miki3421 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
miki3421
marked this pull request as ready for review
September 17, 2026 12:55
Copy link
Copy Markdown
Contributor
|
the ps is replaging the pinned chats with helm to do deploy and I was not meaning that. The goal is to get rid entirely of the descritors from the code and instead install enrtirely with helm as described here https://cert-manager.io/docs/installation/helm/ and here https://docs.nginx.com/nginx-ingress-controller/install/helm/open-source/ the freeze tried to find the name of the image to preload from the descriptos, it should instead just entirely remove the preloading of the ingress controller as it is always installed with helm thus not more preloaded |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the duplicated ingress-nginx and cert-manager manifests with checksum-verified, pinned Helm charts. Existing provider tasks delegate to a shared Bun runner while preserving controller versions, provider-specific settings, and K3s Traefik.
Existing manifest installations require explicit --adopt: the runner checks original manifest fingerprints and live configuration before transferring ownership. Ingress Service addresses and node ports are retained during adoption. cert-manager CRDs remain outside Helm; uninstall preserves CRDs, Issuers, Certificates and TLS Secrets. Validated legacy CRDs receive ownership metadata so reinstall does not require adopting them again. Deployment rollouts are explicitly awaited after Helm completes.
Also updates chart caching/rendering and image discovery, removes eight copied manifests, and adds lifecycle and real-chart rendering tests. The K3s version update in #232 is excluded from this PR.
Addresses apache/openserverless#254.
Validation:
Known validation limitation: K3s 7-static.sh fails because it expects the old static-distributor welcome sentence. The returned page matches oplugins-op/deploy/content/index.html byte for byte; the expected sentence is in a different asset, oplugins/util/upload/assets/index.html. The assertion and application content have not been changed to hide this failure.
Real cloud LoadBalancer/NLB behavior on AKS/EKS/GKE and real Keycloak integration were not tested. Chart pins intentionally preserve the previous versions; upgrading components or replacing the retired ingress-nginx controller is separate work.